rhosocial/yii2-organization

View on GitHub
widgets/views/member-list-tips.php

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php if ($tips): ?>
    <div class="well well-sm">
        <?= Yii::t('organization', 'Member List Directions:') ?>
        <ol>
            <li><?= Yii::t('organization', 'If no search criteria are specified, all members are displayed.') ?></li>
Severity: Major
Found in widgets/views/member-list-tips.php and 1 other location - About 1 hr to fix
widgets/views/organization-list.php on lines 189..204

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line exceeds 120 characters; contains 145 characters
Open

            <li><?= Yii::t('organization', 'When the User ID column is green, it indicates that the user is the current logged-in user.') ?></li>

Line exceeds 120 characters; contains 127 characters
Open

            <li><?= Yii::t('organization', 'If the join time is the same as the last update time, there is no change.') ?></li>

Line exceeds 120 characters; contains 172 characters
Open

            <li><?= Yii::t('organization', 'If you can not see the "Update" or "Remove Member" button, it means that the you do not have corresponding permission.') ?></li>

Expected 1 space after closing parenthesis; found 0
Open

<?php if ($tips): ?>

Expected 1 space after closing parenthesis; found 0
Open

                <?php foreach ($tips as $tip): ?>

Expected 1 space after closing parenthesis; found 0
Open

            <?php if (is_array($tips)): ?>

There are no issues that match your filters.

Category
Status