Sign upLogin

riboseinc/id_pack

View on GitHub
Star

Showing 61 of 61 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              code  = parseInt(revString((rassoc(alpArr, str.charAt(i)) + (1 << tassoc(alpArr, str.charAt(i)))).toString(2)), 2) >> 1; // reverse symbol code to BBC bits
Severity: Major
Found in app/assets/javascripts/lib/uuid-packer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/lib/uuid-packer.js on lines 294..294

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            } else {
              binaryNumber     = this.convertRangesToBinaryNumber(rangesToGroup);
              decimalNumber    = this.convertBinaryNumberToDecimalNumber(binaryNumber);
              encodedString    = this.binaryPrefix + this.encodeDecimalNumber(decimalNumber, outputCharset);
              encodedHashKeys += encodedString;
Severity: Major
Found in app/assets/javascripts/lib/id-packer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/lib/id-packer.js on lines 542..547

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      } else if (rangesToGroup.length > 0) {
        binaryNumber     = this.convertRangesToBinaryNumber(rangesToGroup);
        decimalNumber    = this.convertBinaryNumberToDecimalNumber(binaryNumber);
        encodedString    = this.binaryPrefix + this.encodeDecimalNumber(decimalNumber, outputCharset);
        encodedHashKeys += encodedString;
Severity: Major
Found in app/assets/javascripts/lib/id-packer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/lib/id-packer.js on lines 499..504

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          while (rest >= 4) { // add new UUID caracters to buffer
            rest -= 4; // decrease BBC length
            item = (achr & 15).toString(16) + item; // add new UUID character
            achr >>= 4; // remove used bits from BBC
          }
Severity: Major
Found in app/assets/javascripts/lib/uuid-packer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/lib/uuid-packer.js on lines 358..362

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method alphanum_to_array has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def alphanum_to_array(alphanum_string, del)

      alphanum_array = []
      el = alphanum_string.length
Severity: Minor
Found in lib/id_pack/uuid_packer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

              while (rest >= 4) { // add new UUID caracters to buffer
                rest  -= 4; // decrease number of bits in BBC
                item   = (achr & 15).toString(16) + item; // add new UUID character
                achr >>= 4; // remove used bits from BBC
              }
Severity: Major
Found in app/assets/javascripts/lib/uuid-packer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/lib/uuid-packer.js on lines 304..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function addToRanges has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      this.addToRanges = function(ranges){
        if (! ranges.length) {
          ranges.push(this);
          return ranges;
        }
Severity: Minor
Found in app/assets/javascripts/lib/id-packer.js - About 1 hr to fix

    Method decode has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def decode(encoded_caches)
      curr_encoded_string_prefix = nil

      ids = []
      start_id = 0
    Severity: Minor
    Found in lib/id_pack/id_packer.rb - About 1 hr to fix

      Method decode_sync_str has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def decode_sync_str(sync_str, base_timestamp = 0)
      # format of sync_str:
      # min_last_synced_at,
      # "encoded_0", diff_last_requested_at_0,
      # "encoded_1", diff_last_requested_at_1,
      Severity: Minor
      Found in lib/id_pack/id_packer.rb - About 1 hr to fix

        Function alptoArr has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            alptoArr: function(alpStr, del) {
      var
      alpArr = [],
      el     = alpStr.length,
      charItem,
        Severity: Minor
        Found in app/assets/javascripts/lib/uuid-packer.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    if rest.positive?
            code   = (
              (achr & (2**rest - 1)) + 2**rest
            ).to_s(2).reverse.to_i(2) >> 1
          Severity: Minor
          Found in lib/id_pack/uuid_packer.rb and 1 other location - About 1 hr to fix
          lib/id_pack/uuid_packer.rb on lines 109..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if rest.positive?
        code   = ((achr & (2**rest - 1)) + 2**rest).to_s(2).reverse.to_i(2) >> 1
        code <<= pow - rest - 1
        code <<= 1 if code >= lowhi
          Severity: Minor
          Found in lib/id_pack/uuid_packer.rb and 1 other location - About 1 hr to fix
          lib/id_pack/uuid_packer.rb on lines 176..186

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method decode_sync_str has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def decode_sync_str(sync_str, base_timestamp = 0)
      # format of sync_str:
      # min_last_synced_at,
      # "encoded_0", diff_last_requested_at_0,
      # "encoded_1", diff_last_requested_at_1,
          Severity: Minor
          Found in lib/id_pack/id_packer.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method convert_numbers_to_ranges has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              def convert_numbers_to_ranges(numbers)
      return [] unless numbers.length.positive?

      ranges = []
      range = nil
          Severity: Minor
          Found in lib/id_pack/id_packer.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                        while (rest >= 4) { // add new UUID caracters to buffer
                rest  -= 4; // decrease number of bits in BBC
                item   = (achr & 15).toString(16) + item; // add new UUID character
                achr >>= 4; // remove used bits from BBC
              }
          Severity: Major
          Found in app/assets/javascripts/lib/uuid-packer.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        rest -= 1 if code < lowhi
            Severity: Major
            Found in lib/id_pack/uuid_packer.rb - About 45 mins to fix

              Method encode_sync_str has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def encode_sync_str(id_synced_at)
      min_synced_at = id_synced_at.values.min
      encoded_min_synced_at = LZString.compress_to_encoded_uri_component(min_synced_at.to_s)

      grouped_synced_at = id_synced_at.group_by do |_id, synced_at|
              Severity: Minor
              Found in lib/id_pack/id_packer.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                            if (code < lowhi) { rest -= 1; }
              Severity: Major
              Found in app/assets/javascripts/lib/uuid-packer.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                              if (code >= lowhi) { powC += 1; } // if we get code of long length symbols
                Severity: Major
                Found in app/assets/javascripts/lib/uuid-packer.js - About 45 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              code = (
              alphanum_array.rassoc(str[item])[0] + 2**alphanum_array.rassoc(str[item])[2]
            ).to_s(2).reverse.to_i(2) >> 1
                  Severity: Minor
                  Found in lib/id_pack/uuid_packer.rb and 1 other location - About 15 mins to fix
                  lib/id_pack/uuid_packer.rb on lines 296..301

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 25.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language