richcongress/web-test-bundle

View on GitHub

Showing 12 of 12 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function put(
        string $uri,
        array $queryParams = [],
        array $parameters = [],
        array $files = [],
Severity: Major
Found in WebTest/Client.php and 4 other locations - About 1 hr to fix
WebTest/Client.php on lines 67..87
WebTest/Client.php on lines 89..109
WebTest/Client.php on lines 133..153
WebTest/Client.php on lines 155..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function post(
        string $uri,
        array $queryParams = [],
        array $parameters = [],
        array $files = [],
Severity: Major
Found in WebTest/Client.php and 4 other locations - About 1 hr to fix
WebTest/Client.php on lines 67..87
WebTest/Client.php on lines 111..131
WebTest/Client.php on lines 133..153
WebTest/Client.php on lines 155..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function delete(
        string $uri,
        array $queryParams = [],
        array $parameters = [],
        array $files = [],
Severity: Major
Found in WebTest/Client.php and 4 other locations - About 1 hr to fix
WebTest/Client.php on lines 67..87
WebTest/Client.php on lines 89..109
WebTest/Client.php on lines 111..131
WebTest/Client.php on lines 133..153

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function patch(
        string $uri,
        array $queryParams = [],
        array $parameters = [],
        array $files = [],
Severity: Major
Found in WebTest/Client.php and 4 other locations - About 1 hr to fix
WebTest/Client.php on lines 67..87
WebTest/Client.php on lines 89..109
WebTest/Client.php on lines 111..131
WebTest/Client.php on lines 155..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public function get(
        string $uri,
        array $queryParams = [],
        array $parameters = [],
        array $files = [],
Severity: Major
Found in WebTest/Client.php and 4 other locations - About 1 hr to fix
WebTest/Client.php on lines 89..109
WebTest/Client.php on lines 111..131
WebTest/Client.php on lines 133..153
WebTest/Client.php on lines 155..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function resolve has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public static function resolve(TestCase $instance, ContainerInterface $container): void
    {
        $reflectionClass = new \ReflectionClass($instance);
        $publicProperties = $reflectionClass->getProperties(\ReflectionProperty::IS_PUBLIC);

Severity: Minor
Found in ServiceResolver/PublicPropertyServiceResolver.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method post has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $uri,
        array $queryParams = [],
        array $parameters = [],
        array $files = [],
        array $server = [],
Severity: Major
Found in WebTest/Client.php - About 1 hr to fix

    Method request has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $method,
            string $uri,
            array $parameters = [],
            array $files = [],
            array $server = [],
    Severity: Major
    Found in WebTest/Client.php - About 1 hr to fix

      Method get has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $uri,
              array $queryParams = [],
              array $parameters = [],
              array $files = [],
              array $server = [],
      Severity: Major
      Found in WebTest/Client.php - About 1 hr to fix

        Method put has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $uri,
                array $queryParams = [],
                array $parameters = [],
                array $files = [],
                array $server = [],
        Severity: Major
        Found in WebTest/Client.php - About 1 hr to fix

          Method delete has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $uri,
                  array $queryParams = [],
                  array $parameters = [],
                  array $files = [],
                  array $server = [],
          Severity: Major
          Found in WebTest/Client.php - About 1 hr to fix

            Method patch has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    string $uri,
                    array $queryParams = [],
                    array $parameters = [],
                    array $files = [],
                    array $server = [],
            Severity: Major
            Found in WebTest/Client.php - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language