Bourbon::SassExtensions::Functions::Compact#compact calls 'args.first' 3 times Open
if args.size == 1 && args.first.is_a?(Sass::Script::List)
args = args.first.value
sep = args.first.separator- Read upRead up
- Exclude checks
Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.
Reek implements a check for Duplicate Method Call.
Example
Here's a very much simplified and contrived example. The following method will report a warning:
def double_thing()
@other.thing + @other.thing
endOne quick approach to silence Reek would be to refactor the code thus:
def double_thing()
thing = @other.thing
thing + thing
endA slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:
class Other
def double_thing()
thing + thing
end
endThe approach you take will depend on balancing other factors in your code.
Bourbon::SassExtensions::Functions::Compact#compact doesn't depend on instance state (maybe move it to another class?) Open
def compact(*args)- Read upRead up
- Exclude checks
A Utility Function is any instance method that has no dependency on the state of the instance.
Bourbon::SassExtensions::Functions::Compact#compact has the variable name 'a' Open
Sass::Script::List.new(args.reject{|a| !a.to_bool}, sep)- Read upRead up
- Exclude checks
An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.
Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.