Sign upLogin

rilwis/meta-box

View on GitHub
Star

Showing 254 of 254 total issues

Avoid too many return statements within this function.
Open

            return val;
Severity: Major
Found in js/validation/jquery.validate.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return control === control_digit || control === control_letter;
    Severity: Major
    Found in js/validation/additional-methods.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return false;
      Severity: Major
      Found in js/validation/additional-methods.js - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $value;
        Severity: Major
        Found in inc/shortcode.php - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return value.length === 16;
          Severity: Major
          Found in js/validation/additional-methods.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if ( this.settings.highlight ) {
                    this.settings.highlight.call( this, error.element, this.settings.errorClass, this.settings.validClass );
                }
            Severity: Minor
            Found in js/validation/jquery.validate.js and 1 other location - About 30 mins to fix
            js/validation/jquery.validate.js on lines 935..937

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            for ( i = 0, elements = this.validElements(); elements[ i ]; i++ ) {
                    this.settings.unhighlight.call( this, elements[ i ], this.settings.errorClass, this.settings.validClass );
                }
            Severity: Minor
            Found in js/validation/jquery.validate.js and 1 other location - About 30 mins to fix
            js/validation/jquery.validate.js on lines 921..923

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected static function transform( $input_name ) {
        // @codingStandardsIgnoreStart
        foreach ( $_FILES[ $input_name ] as $key => $list ) {
            foreach ( $list as $index => $value ) {
                $file_key = "{$input_name}_{$index}";
            Severity: Minor
            Found in inc/fields/file.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function set( &$array, $key, $value ) {
        if ( is_null( $key ) ) {
            $array = $value;
            return $array;
        }
            Severity: Minor
            Found in src/Support/Arr.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function request( $endpoint, $args = [] ) {
        $args = wp_parse_args( $args, [
            'key'   => $this->option->get_api_key(),
            'url'   => home_url(),
            'force' => false,
            Severity: Minor
            Found in src/Updater/Checker.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function normalize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function normalize( $field ) {
        $field = wp_parse_args( $field, [
            'placeholder'     => __( 'Select an icon', 'meta-box' ),
            'icon_css'        => '',
            'icon_set'        => '',
            Severity: Minor
            Found in inc/fields/icon.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function call() {
        $args = func_get_args();

        $check = reset( $args );
            Severity: Minor
            Found in inc/field.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function value( $new, $old, $post_id, $field ) {
        $input = $field['index'] ?? $field['input_name'];

        // @codingStandardsIgnoreLine
        if ( empty( $input ) || empty( $_FILES[ $input ] ) ) {
            Severity: Minor
            Found in inc/fields/file.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function value( $new, $old, $post_id, $field ) {
        if ( $field['timestamp'] ) {
            if ( is_array( $new ) ) {
                return $new['timestamp'];
            }
            Severity: Minor
            Found in inc/fields/datetime.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language