Sign upLogin

rinvex/cortex-categories

View on GitHub
Star

Showing 5 of 5 total issues

Avoid excessively long class names like AlterCategoriesTableAddStyleAndIconColumns. Keep class name length under 40.
Open

class AlterCategoriesTableAddStyleAndIconColumns extends Migration
{
    /**
     * Run the migrations.
     *
Severity: Minor
Found in database/migrations/2021_01_01_000002_alter_categories_table_add_style_and_icon_columns.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Cortex\Categories\Events;
Severity: Major
Found in src/Events/CategoryRestored.php and 1 other location - About 1 hr to fix
src/Events/CategoryUpdated.php on lines 1..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Cortex\Categories\Events;
Severity: Major
Found in src/Events/CategoryUpdated.php and 1 other location - About 1 hr to fix
src/Events/CategoryRestored.php on lines 1..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid assigning values to variables in if clauses and the like (line '107', column '66').
Open

    protected function form(Request $request, Category $category)
    {
        if (! $category->exists && $request->has('replicate') && $replicated = $category->resolveRouteBinding($request->input('replicate'))) {
            $category = $replicated->replicate();
        }
Severity: Minor
Found in src/Http/Controllers/Adminarea/CategoriesController.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The variable $ParentCategories is not named in camelCase.
Open

    protected function form(Request $request, Category $category)
    {
        if (! $category->exists && $request->has('replicate') && $replicated = $category->resolveRouteBinding($request->input('replicate'))) {
            $category = $replicated->replicate();
        }
Severity: Minor
Found in src/Http/Controllers/Adminarea/CategoriesController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language