Showing 8 of 8 total issues
Function handle
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public function handle(): void
{
$path = $this->argument('path');
$name = $this->option('name');
$type = $this->option('type');
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method handle
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function handle(): void
{
$path = $this->argument('path');
$name = $this->option('name');
$type = $this->option('type');
- Create a ticketCreate a ticket
Method index
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function index(Request $request, Terminal $terminal)
{
$token = null;
if ($request->hasSession() === true) {
- Create a ticketCreate a ticket
Missing class import via use statement (line '35', column '28'). Open
$application = new \Composer\Console\Application();
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid unused parameters such as '$key'. Open
$routes->transform(function (Route $route, $key) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The method handle() has an NPath complexity of 216. The configured NPath complexity threshold is 200. Open
public function handle(): void
{
$path = $this->argument('path');
$name = $this->option('name');
$type = $this->option('type');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method handle() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open
public function handle(): void
{
$path = $this->argument('path');
$name = $this->option('name');
$type = $this->option('type');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
register accesses the super-global variable $_SERVER. Open
public function register(): void
{
// Register console commands
$this->registerCommands($this->commands);
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}