Method render
has 78 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function render($request, Throwable $e)
{
if ($e instanceof TokenMismatchException) {
return intend([
'back' => true,
- Create a ticketCreate a ticket
Function render
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public function render($request, Throwable $e)
{
if ($e instanceof TokenMismatchException) {
return intend([
'back' => true,
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $this->prepareResponse($request, $e);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'url' => Route::has($route) ? route($route) : route("{$request->accessarea()}.home"),
'with' => ['warning' => trans('cortex/foundation::messages.resource_not_found', ['resource' => $resource, 'identifier' => $matches[0]])],
], 404);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'url' => route($request->accessarea().'.cortex.auth.account.login'),
'with' => ['warning' => trans('cortex/auth::messages.unauthenticated')],
], 401);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'back' => true,
'withInput' => $request->all(),
'with' => ['warning' => $e->getMessage()],
], $e->getStatusCode()); // 429
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'url' => in_array($request->accessarea(), ['tenantarea', 'managerarea']) ? route('tenantarea.home') : route('frontarea.home'),
'with' => ['warning' => $e->getMessage()],
], 403);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return parent::render($request, $e);
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'url' => $originalUrl !== $localizedUrl ? $localizedUrl : route("{$request->accessarea()}.home"),
'with' => ['warning' => $e->getMessage()],
], $e->getStatusCode()); // 404
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'url' => route('frontarea.home'),
'with' => ['warning' => $e->getMessage()],
], 404); // 429
- Create a ticketCreate a ticket
Avoid too many return
statements within this method. Open
return intend([
'url' => route("{$request->accessarea()}.home"),
'with' => ['warning' => $e->getMessage()],
], 404);
- Create a ticketCreate a ticket
The method render() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10. Open
public function render($request, Throwable $e)
{
if ($e instanceof TokenMismatchException) {
return intend([
'back' => true,
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The class ExceptionHandler has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13. Open
class ExceptionHandler extends BaseExceptionHandler
{
/**
* A list of the exception types that are not reported.
*
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid assigning values to variables in if clauses and the like (line '191', column '28'). Open
protected function renderHttpException(HttpExceptionInterface $e)
{
if (view()->exists($view = $this->getHttpExceptionView($e))) {
return response()->view($view, ['errors' => new ViewErrorBag(), 'exception' => $e], $e->getStatusCode(), $e->getHeaders());
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid unused parameters such as '$e'. Open
$this->reportable(function (Throwable $e) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using empty try-catch blocks in render. Open
} catch (Exception $e) {
}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
EmptyCatchBlock
Since: 2.7.0
Usually empty try-catch is a bad idea because you are silently swallowing an error condition and then continuing execution. Occasionally this may be the right thing to do, but often it's a sign that a developer saw an exception, didn't know what to do about it, and so used an empty catch to silence the problem.
Example
class Foo {
public function bar()
{
try {
// ...
} catch (Exception $e) {} // empty catch block
}
}