Method timeoffsets
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
function timeoffsets()
{
return [
'-1200' => 'UTC -12:00',
'-1100' => 'UTC -11:00',
- Create a ticketCreate a ticket
Function array_diff_assoc_recursive
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
function array_diff_assoc_recursive(array $array1, array $array2, bool $onlyDiff = true)
{
$difference = [];
foreach ($array1 as $key => $value) {
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function array_search_recursive
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
function array_search_recursive($needle, $haystack)
{
foreach ($haystack as $key => $value) {
$current_key = $key;
if ($needle === $value || (is_array($value) && array_search_recursive($needle, $value) !== false)) {
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function get_str_endswith
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function get_str_endswith($haystack, $needles)
{
foreach ((array) $needles as $needle) {
if (! empty($needle) && mb_substr($haystack, -mb_strlen($needle)) === (string) $needle) {
return $needle;
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function get_str_contains
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function get_str_contains($haystack, $needles)
{
foreach ((array) $needles as $needle) {
if (! empty($needle) && mb_strpos($haystack, $needle) !== false) {
return $needle;
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid assigning values to variables in if clauses and the like (line '142', column '35'). Open
function array_diff_assoc_recursive(array $array1, array $array2, bool $onlyDiff = true)
{
$difference = [];
foreach ($array1 as $key => $value) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The variable $current_key is not named in camelCase. Open
function array_search_recursive($needle, $haystack)
{
foreach ($haystack as $key => $value) {
$current_key = $key;
if ($needle === $value || (is_array($value) && array_search_recursive($needle, $value) !== false)) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $current_key is not named in camelCase. Open
function array_search_recursive($needle, $haystack)
{
foreach ($haystack as $key => $value) {
$current_key = $key;
if ($needle === $value || (is_array($value) && array_search_recursive($needle, $value) !== false)) {
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}