Sign upLogin

ripta/drydock

View on GitHub
Star
lib/drydock/instructions/import.rb

Summary

Maintainability
A
40 mins
Test Coverage

Assignment Branch Condition size for run_with_spool! is too high. [21.21/15]
Open

      def run_with_spool!
        spool_file = Tempfile.new('drydock')
        log_info("Spooling to #{spool_file.path}")

        source_chain.run("# EXPORT #{path}", no_commit: true) do |source_container|
Severity: Minor
Found in lib/drydock/instructions/import.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            source_chain.run("# EXPORT #{path}", no_commit: true) do |source_container|
              source_container.archive_get(path + '/.') do |chunk|
                output.write(chunk.to_s).tap { |b| @total_size += b }
Severity: Minor
Found in lib/drydock/instructions/import.rb and 1 other location - About 20 mins to fix
lib/drydock/instructions/import.rb on lines 31..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        source_chain.run("# EXPORT #{path}", no_commit: true) do |source_container|
          source_container.archive_get(path + '/.') do |chunk|
            spool_file.write(chunk.to_s).tap { |b| @total_size += b }
Severity: Minor
Found in lib/drydock/instructions/import.rb and 1 other location - About 20 mins to fix
lib/drydock/instructions/import.rb on lines 50..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Empty line missing at class body beginning.
Open

      attr_accessor :force, :spool, :total_size
Severity: Minor
Found in lib/drydock/instructions/import.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

There are no issues that match your filters.

Category
Status