Sign upLogin

rjrodger/patrun

View on GitHub
Star

Showing 19 of 19 total issues

Function Patrun has a Cognitive Complexity of 275 (exceeds 5 allowed). Consider refactoring.
Open

function Patrun(custom?: any) {
  custom = custom || {}

  var self: any = {}
  var top: any = {}
Severity: Minor
Found in patrun.ts - About 5 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Patrun has 354 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Patrun(custom?: any) {
  custom = custom || {}

  var self: any = {}
  var top: any = {}
Severity: Major
Found in patrun.ts - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (mv) {
          var g = (keymap.g = keymap.g || {})
          var ga = (g[key] = g[key] || [])
          mv = (ga.find((gmv: MatchValue) => gmv.same(mv)) ||
            (ga.push(mv), mv)) as MatchValue
    Severity: Major
    Found in patrun.ts and 1 other location - About 6 hrs to fix
    patrun.ts on lines 131..139

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 157.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (mv) {
          var g = (keymap.g = keymap.g || {})
          var ga = (g[key] = g[key] || [])
          mv = (ga.find((gmv: MatchValue) => gmv.same(mv)) ||
            (ga.push(mv), mv)) as MatchValue
    Severity: Major
    Found in patrun.ts and 1 other location - About 6 hrs to fix
    patrun.ts on lines 94..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 157.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File patrun.ts has 375 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* Copyright (c) 2013-2022 Richard Rodger, MIT License */

// TODO: matchers should accept string[] of key names - only operate on these keys

// TODO: expose walk as method for general purpose
    Severity: Minor
    Found in patrun.ts - About 5 hrs to fix

      Function add has 86 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        self.add = function (pat: any, data: any) {
    pat = { ...pat }

    var customizer =
      'function' === typeof custom ? custom.call(self, pat, data) : null
      Severity: Major
      Found in patrun.ts - About 3 hrs to fix

        Function find has 65 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          self.find = function (pat: any, exact: any, collect: any) {
    if (null == pat) return null

    var keymap: any = top
    var data: any = void 0 === top.d ? null : top.d
        Severity: Major
        Found in patrun.ts - About 2 hrs to fix

          Function toString has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            self.toString = function (first: any, second: any) {
    var tree = true === first ? true : !!second

    var dstr =
      'function' === typeof first
          Severity: Major
          Found in patrun.ts - About 2 hrs to fix

            Function list has 58 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              self.list = function (pat: any, exact: boolean) {
    pat = pat || {}

    function descend(keymap: any, match: any, missing: any, acc: any) {
      if (keymap.v) {
            Severity: Major
            Found in patrun.ts - About 2 hrs to fix

              Function walk has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function walk(n: any, o: any, d: any, vs: any) {
      var vsc

      if (void 0 !== n.d) {
        o.push(' ' + dstr(n.d))
              Severity: Minor
              Found in patrun.ts - About 1 hr to fix

                Function descend has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function descend(keymap: any, match: any, missing: any, acc: any) {
      if (keymap.v) {
        var key = keymap.k
        var gexval = Gex(
          pat ? (null == pat[key] ? (exact ? null : '*') : pat[key]) : '*',
                Severity: Minor
                Found in patrun.ts - About 1 hr to fix

                  Function remove has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    self.remove = function (pat: any) {
    var keymap = top
    var data = null
    var key
    var path = []
                  Severity: Minor
                  Found in patrun.ts - About 1 hr to fix

                    Avoid deeply nested control flow statements.
                    Open

                            if (g) {
          keymap.s.g = g
        }
                    Severity: Major
                    Found in patrun.ts - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                              if (s) {
          keymap.s.s = s
        }
                      Severity: Major
                      Found in patrun.ts - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                    if (ga[gi].match(val)) {
              nextkeymap = ga[gi].keymap
              break
            }
                        Severity: Major
                        Found in patrun.ts - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                  if (keymap.g) {
          keymap.g = {}
        }
                          Severity: Major
                          Found in patrun.ts - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                    if (mv) {
          var g = (keymap.g = keymap.g || {})
          var ga = (g[key] = g[key] || [])
          mv = (ga.find((gmv: MatchValue) => gmv.same(mv)) ||
            (ga.push(mv), mv)) as MatchValue
                            Severity: Major
                            Found in patrun.ts - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                          if (mvs[mvi].fix === pat[key]) {
              path.push({ km: keymap, v: pat[key], mv: mvs[mvi] })
              nextkeymap = mvs[mvi].keymap
              break
            }
                              Severity: Major
                              Found in patrun.ts - About 45 mins to fix

                                Consider simplifying this complex logical expression.
                                Open

                                        if (mv) {
          var g = (keymap.g = keymap.g || {})
          var ga = (g[key] = g[key] || [])
          mv = (ga.find((gmv: MatchValue) => gmv.same(mv)) ||
            (ga.push(mv), mv)) as MatchValue
                                Severity: Major
                                Found in patrun.ts - About 40 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language