rkokkelk/siso

View on GitHub
app/helpers/ip_helper.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method verifyIP has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def verifyIP(ip)
    unless @@ranges
      Rails.logger.error { "Cannot verify IP, @ranges(#{@@ranges})" }
      return false
    end
Severity: Minor
Found in app/helpers/ip_helper.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use snake_case for method names.
Open

  def verifyIP(ip)
Severity: Minor
Found in app/helpers/ip_helper.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Use snake_case for method names.
Open

  def create_CIDR(config_range)
Severity: Minor
Found in app/helpers/ip_helper.rb by rubocop

This cop makes sure that all methods use the configured style, snake_case or camelCase, for their names.

Example: EnforcedStyle: snake_case (default)

# bad
def fooBar; end

# good
def foo_bar; end

Example: EnforcedStyle: camelCase

# bad
def foo_bar; end

# good
def fooBar; end

Replace class var @@ranges with a class instance var.
Open

  @@ranges ||= []
Severity: Minor
Found in app/helpers/ip_helper.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

There are no issues that match your filters.

Category
Status