Sign upLogin

rkrage/pg_party

View on GitHub
Star

Showing 11 of 12 total issues

Class AdapterDecorator has 47 methods (exceeds 20 allowed). Consider refactoring.
Confirmed

  class AdapterDecorator < SimpleDelegator
    SUPPORTED_PARTITION_TYPES = %i[range list hash].freeze

    def initialize(adapter)
      super(adapter)
Severity: Minor
Found in lib/pg_party/adapter_decorator.rb - About 6 hrs to fix

    File adapter_decorator.rb has 359 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "digest"
require 'parallel'

module PgParty
  class AdapterDecorator < SimpleDelegator
    Severity: Minor
    Found in lib/pg_party/adapter_decorator.rb - About 4 hrs to fix

      Method create_table_like has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def create_table_like(table_name, new_table_name, **options)
      primary_key           = options.fetch(:primary_key) { calculate_primary_key(table_name) }
      partition_key         = options.fetch(:partition_key, nil)
      partition_type        = options.fetch(:partition_type, nil)
      create_with_pks       = options.fetch(
      Severity: Minor
      Found in lib/pg_party/adapter_decorator.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method recursive_add_index has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def recursive_add_index(table_name:, index_name:, index_type:, index_columns:, index_options:, using:, algorithm:,
                            in_threads: nil, _parent_index_name: nil, _created_index_names: [])
      partitions = partitions_for_table_name(table_name, include_subpartitions: false)
      updated_name = _created_index_names.empty? ? index_name : generate_index_name(index_name, table_name)
      Severity: Minor
      Found in lib/pg_party/adapter_decorator.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_partition has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def create_partition(table_name, type, partition_key, **options, &blk)
      modified_options      = options.except(:id, :primary_key, :template, :create_with_primary_key)
      template              = options.fetch(:template, PgParty.config.create_template_tables)
      id                    = options.fetch(:id, :bigserial)
      primary_key           = options.fetch(:primary_key) { calculate_primary_key(table_name) }
      Severity: Minor
      Found in lib/pg_party/adapter_decorator.rb - About 1 hr to fix

        Method recursive_add_index has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def recursive_add_index(table_name:, index_name:, index_type:, index_columns:, index_options:, using:, algorithm:,
                            in_threads: nil, _parent_index_name: nil, _created_index_names: [])
      partitions = partitions_for_table_name(table_name, include_subpartitions: false)
      updated_name = _created_index_names.empty? ? index_name : generate_index_name(index_name, table_name)
        Severity: Minor
        Found in lib/pg_party/adapter_decorator.rb - About 1 hr to fix

          Method extract_index_options has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def extract_index_options(add_index_options_result)
      # Rails 6.1 changes the result of #add_index_options
      index_definition = add_index_options_result.first
      return add_index_options_result unless index_definition.is_a?(ActiveRecord::ConnectionAdapters::IndexDefinition)
          Severity: Minor
          Found in lib/pg_party/adapter_decorator.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_table_like has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def create_table_like(table_name, new_table_name, **options)
      primary_key           = options.fetch(:primary_key) { calculate_primary_key(table_name) }
      partition_key         = options.fetch(:partition_key, nil)
      partition_type        = options.fetch(:partition_type, nil)
      create_with_pks       = options.fetch(
          Severity: Minor
          Found in lib/pg_party/adapter_decorator.rb - About 1 hr to fix

            Method create_partition has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def create_partition(table_name, type, partition_key, **options, &blk)
            Severity: Minor
            Found in lib/pg_party/adapter_decorator.rb - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              module PgParty
  module Model
    module RangeMethods
      ruby2_keywords def create_partition(*args)
        PgParty::ModelDecorator.new(self).create_range_partition(*args)
              Severity: Minor
              Found in lib/pg_party/model/range_methods.rb and 1 other location - About 30 mins to fix
              lib/pg_party/model/list_methods.rb on lines 6..18

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              module PgParty
  module Model
    module ListMethods
      ruby2_keywords def create_partition(*args)
        PgParty::ModelDecorator.new(self).create_list_partition(*args)
              Severity: Minor
              Found in lib/pg_party/model/list_methods.rb and 1 other location - About 30 mins to fix
              lib/pg_party/model/range_methods.rb on lines 6..18

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language