Sign upLogin

rl404/go-malscraper

View on GitHub
Star
internal/validator/search.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Validator.SearchAnime has 10 return statements (exceeds 4 allowed).
Open

func (v *Validator) SearchAnime(query model.Query) ([]model.AnimeSearch, int, error) {
    if len(query.Title) < 3 {
        return nil, http.StatusBadRequest, errors.Err3LettersSearch
    }
    if query.Page < 0 {
Severity: Major
Found in internal/validator/search.go - About 1 hr to fix

    Method Validator.SearchManga has 9 return statements (exceeds 4 allowed).
    Open

    func (v *Validator) SearchManga(query model.Query) ([]model.MangaSearch, int, error) {
    if len(query.Title) < 3 {
        return nil, http.StatusBadRequest, errors.Err3LettersSearch
    }
    if query.Page < 0 {
    Severity: Major
    Found in internal/validator/search.go - About 55 mins to fix

      Method Validator.SearchClub has 5 return statements (exceeds 4 allowed).
      Open

      func (v *Validator) SearchClub(query model.ClubQuery) ([]model.ClubSearch, int, error) {
    if len(query.Name) < 3 {
        return nil, http.StatusBadRequest, errors.Err3LettersSearch
    }
    if query.Page < 0 {
      Severity: Major
      Found in internal/validator/search.go - About 35 mins to fix

        Method Validator.SearchUser has 5 return statements (exceeds 4 allowed).
        Open

        func (v *Validator) SearchUser(query model.UserQuery) ([]model.UserSearch, int, error) {
    if len(query.Username) < 3 {
        return nil, http.StatusBadRequest, errors.Err3LettersSearch
    }
    if query.Page < 0 {
        Severity: Major
        Found in internal/validator/search.go - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (v *Validator) SearchCharacter(name string, page int) ([]model.CharacterSearch, int, error) {
    if len(name) < 3 {
        return nil, http.StatusBadRequest, errors.Err3LettersSearch
    }
    if page <= 0 {
          Severity: Minor
          Found in internal/validator/search.go and 1 other location - About 50 mins to fix
          internal/validator/search.go on lines 94..102

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (v *Validator) SearchPeople(name string, page int) ([]model.PeopleSearch, int, error) {
    if len(name) < 3 {
        return nil, http.StatusBadRequest, errors.Err3LettersSearch
    }
    if page <= 0 {
          Severity: Minor
          Found in internal/validator/search.go and 1 other location - About 50 mins to fix
          internal/validator/search.go on lines 83..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 119.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status