Sign upLogin

rl404/go-malscraper

View on GitHub
Star

Showing 389 of 389 total issues

Similar blocks of code found in 13 locations. Consider refactoring.
Open

func (m *Malscraper) GetMangaWithGenre(id int, page ...int) ([]model.MangaItem, int, error) {
    p := 1
    if len(page) > 0 {
        p = page[0]
    }
Severity: Major
Found in api_genre.go and 12 other locations - About 30 mins to fix
api_anime.go on lines 40..46
api_anime.go on lines 58..64
api_club.go on lines 28..34
api_genre.go on lines 29..35
api_manga.go on lines 17..23
api_producer_magazine.go on lines 17..23
api_producer_magazine.go on lines 35..41
api_search.go on lines 85..91
api_search.go on lines 96..102
api_user.go on lines 31..37
api_user.go on lines 59..65
api_user.go on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

func (m *Malscraper) SearchCharacter(name string, page ...int) ([]model.CharacterSearch, int, error) {
    p := 1
    if len(page) > 0 {
        p = page[0]
    }
Severity: Major
Found in api_search.go and 12 other locations - About 30 mins to fix
api_anime.go on lines 40..46
api_anime.go on lines 58..64
api_club.go on lines 28..34
api_genre.go on lines 29..35
api_genre.go on lines 47..53
api_manga.go on lines 17..23
api_producer_magazine.go on lines 17..23
api_producer_magazine.go on lines 35..41
api_search.go on lines 96..102
api_user.go on lines 31..37
api_user.go on lines 59..65
api_user.go on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

func (m *Malscraper) GetMangaReview(id int, page ...int) ([]model.Review, int, error) {
    p := 1
    if len(page) > 0 {
        p = page[0]
    }
Severity: Major
Found in api_manga.go and 12 other locations - About 30 mins to fix
api_anime.go on lines 40..46
api_anime.go on lines 58..64
api_club.go on lines 28..34
api_genre.go on lines 29..35
api_genre.go on lines 47..53
api_producer_magazine.go on lines 17..23
api_producer_magazine.go on lines 35..41
api_search.go on lines 85..91
api_search.go on lines 96..102
api_user.go on lines 31..37
api_user.go on lines 59..65
api_user.go on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

func (m *Malscraper) SearchPeople(name string, page ...int) ([]model.PeopleSearch, int, error) {
    p := 1
    if len(page) > 0 {
        p = page[0]
    }
Severity: Major
Found in api_search.go and 12 other locations - About 30 mins to fix
api_anime.go on lines 40..46
api_anime.go on lines 58..64
api_club.go on lines 28..34
api_genre.go on lines 29..35
api_genre.go on lines 47..53
api_manga.go on lines 17..23
api_producer_magazine.go on lines 17..23
api_producer_magazine.go on lines 35..41
api_search.go on lines 85..91
api_user.go on lines 31..37
api_user.go on lines 59..65
api_user.go on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

func (m *Malscraper) GetMagazine(id int, page ...int) ([]model.MangaItem, int, error) {
    p := 1
    if len(page) > 0 {
        p = page[0]
    }
Severity: Major
Found in api_producer_magazine.go and 12 other locations - About 30 mins to fix
api_anime.go on lines 40..46
api_anime.go on lines 58..64
api_club.go on lines 28..34
api_genre.go on lines 29..35
api_genre.go on lines 47..53
api_manga.go on lines 17..23
api_producer_magazine.go on lines 17..23
api_search.go on lines 85..91
api_search.go on lines 96..102
api_user.go on lines 31..37
api_user.go on lines 59..65
api_user.go on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

func (m *Malscraper) GetUserReview(username string, page ...int) ([]model.Review, int, error) {
    p := 1
    if len(page) > 0 {
        p = page[0]
    }
Severity: Major
Found in api_user.go and 12 other locations - About 30 mins to fix
api_anime.go on lines 40..46
api_anime.go on lines 58..64
api_club.go on lines 28..34
api_genre.go on lines 29..35
api_genre.go on lines 47..53
api_manga.go on lines 17..23
api_producer_magazine.go on lines 17..23
api_producer_magazine.go on lines 35..41
api_search.go on lines 85..91
api_search.go on lines 96..102
api_user.go on lines 31..37
api_user.go on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (nl *newsList) getUsername(eachNews *goquery.Selection) string {
    user, _ := eachNews.Find(".information").Find("p").First().Find("a").First().Attr("href")
    return utils.GetValueFromSplit(user, "/", 4)
}
Severity: Minor
Found in internal/parser/news/news_list.go and 1 other location - About 30 mins to fix
internal/parser/article/article_list.go on lines 87..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (a *articles) getUsername(eachF *goquery.Selection) string {
    user, _ := eachF.Find(".information").Find("p").First().Find("a").First().Attr("href")
    return utils.GetValueFromSplit(user, "/", 4)
}
Severity: Minor
Found in internal/parser/article/article_list.go and 1 other location - About 30 mins to fix
internal/parser/news/news_list.go on lines 72..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function StrToDate has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func StrToDate(str string) (y, m, d int) {
    str = strings.TrimSpace(str)
    if str == "" {
        return 0, 0, 0
    }
Severity: Minor
Found in pkg/utils/time.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language