Sign upLogin

rloomans/new-teamtemp

View on GitHub
Star
teamtemp/tests/forms/test_survey_settings_form.py

Summary

Maintainability
A
0 mins
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

    def test_invalid_tz_survey_settings_form(self):
        self.form_data["default_tz"] = "toast"
        form = SurveySettingsForm(data=self.form_data)
        self.assertFalse(form.is_valid())
Severity: Major
Found in teamtemp/tests/forms/test_survey_settings_form.py and 4 other locations - About 1 hr to fix
teamtemp/tests/forms/test_create_survey_form.py on lines 27..30
teamtemp/tests/forms/test_create_survey_form.py on lines 32..35
teamtemp/tests/forms/test_survey_settings_form.py on lines 42..45
teamtemp/tests/forms/test_survey_settings_form.py on lines 47..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

    def test_invalid_archive_date_survey_settings_form(self):
        self.form_data["next_archive_date"] = "01/01/2000"
        form = SurveySettingsForm(data=self.form_data)
        self.assertFalse(form.is_valid())
Severity: Major
Found in teamtemp/tests/forms/test_survey_settings_form.py and 4 other locations - About 1 hr to fix
teamtemp/tests/forms/test_create_survey_form.py on lines 27..30
teamtemp/tests/forms/test_create_survey_form.py on lines 32..35
teamtemp/tests/forms/test_survey_settings_form.py on lines 32..35
teamtemp/tests/forms/test_survey_settings_form.py on lines 47..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Invalid

    def test_invalid_survey_type_survey_settings_form(self):
        self.form_data["survey_type"] = "TEST"
        form = SurveySettingsForm(data=self.form_data)
        self.assertFalse(form.is_valid())
Severity: Major
Found in teamtemp/tests/forms/test_survey_settings_form.py and 4 other locations - About 1 hr to fix
teamtemp/tests/forms/test_create_survey_form.py on lines 27..30
teamtemp/tests/forms/test_create_survey_form.py on lines 32..35
teamtemp/tests/forms/test_survey_settings_form.py on lines 32..35
teamtemp/tests/forms/test_survey_settings_form.py on lines 42..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    def test_existing_survey_settings_form(self):
        form = SurveySettingsForm(data=self.form_data)
        self.assertTrue(form.is_valid())
Severity: Minor
Found in teamtemp/tests/forms/test_survey_settings_form.py and 1 other location - About 30 mins to fix
teamtemp/tests/forms/test_create_survey_form.py on lines 23..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status