Showing 3 of 3 total issues
Method parse_station
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Open
def parse_station(xml_node)
station = {}
xml_node.elements.each do |node|
station[:id] = node.text.to_i if node.node_name.eql? 'id'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method run
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def run
program :name, 'London Bike Hire CLI'
program :version, LondonBikeHireCli::VERSION
program :description, 'A command line interface to the London Bike Hire API.'
Method nearest
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
def nearest(params: {})
unless params[:search_term].nil? ^ params[:id].nil?
error = 'Please use either `search_term` or `id` not both.'
renderer.render(:error, query: "nearest: #{params}", error: error)
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"