Sign upLogin

robertgauld/OSMExtender

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class ApplicationController has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  protect_from_forgery :with => :exception
  before_action :require_login
  before_action :require_gdpr_consent
  before_action :set_paper_trail_whodunnit
Severity: Minor
Found in app/controllers/application_controller.rb - About 4 hrs to fix

    File application_controller.rb has 261 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ApplicationController < ActionController::Base
  protect_from_forgery :with => :exception
  before_action :require_login
  before_action :require_gdpr_consent
  before_action :set_paper_trail_whodunnit
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 2 hrs to fix

      Method require_section_subscription has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def require_section_subscription(level, section=current_section)
    section = Osm::Section.get(api, section) unless section.is_a?(Osm::Section)
    return unless section.nil? || !section.subscription_at_least?(level)
    flash[:error] = "#{section.nil? ? 'Unknown section' : section.name} does not have the right subscription level for that (#{Osm::SUBSCRIPTION_LEVEL_NAMES[level]} subscription or better required)."
    redirect_back_or_to(current_user ? my_page_path : signin_path)
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status