Sign upLogin

robertgauld/OSMExtender

View on GitHub
Star
app/controllers/osm_exports_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Method members has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def members
    require_osm_permission :read, :member

    members = Osm::Member.get_for_section(osm_api, current_section, params[:term_id])
Severity: Major
Found in app/controllers/osm_exports_controller.rb - About 6 hrs to fix

    Method members has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

      def members
    require_osm_permission :read, :member

    members = Osm::Member.get_for_section(osm_api, current_section, params[:term_id])
    Severity: Minor
    Found in app/controllers/osm_exports_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File osm_exports_controller.rb has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class OsmExportsController < ApplicationController
  before_action :require_connected_to_osm

  before_action {
    params[:file_options] ||= {}
    Severity: Minor
    Found in app/controllers/osm_exports_controller.rb - About 2 hrs to fix

      Method flexi_record has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def flexi_record
    require_osm_permission :read, :flexi
    flexi_record = nil
    flexi_record_id = params[:flexi_record_id].to_i
      Severity: Minor
      Found in app/controllers/osm_exports_controller.rb - About 1 hr to fix

        Method programme_meetings has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def programme_meetings
    require_osm_permission :read, :programme

    headers = [
      'ID',
        Severity: Minor
        Found in app/controllers/osm_exports_controller.rb - About 1 hr to fix

          Method flexi_record has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def flexi_record
    require_osm_permission :read, :flexi
    flexi_record = nil
    flexi_record_id = params[:flexi_record_id].to_i
          Severity: Minor
          Found in app/controllers/osm_exports_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if enabled_contacts[:primary_contact]
        member.push *i.primary_contact.attributes.values_at(*%w{ first_name last_name address_1 address_2 address_3 address_4 postcode phone_1 receive_phone_1 phone_2 receive_phone_2 email_1 receive_email_1 email_2 receive_email_2 })
        member.push *i.primary_contact.additional_information.values_at(*additional_information_fields_for[:primary_contact])
      end
          Severity: Minor
          Found in app/controllers/osm_exports_controller.rb and 1 other location - About 45 mins to fix
          app/controllers/osm_exports_controller.rb on lines 202..205

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if enabled_contacts[:secondary_contact]
        member.push *i.secondary_contact.attributes.values_at(*%w{ first_name last_name address_1 address_2 address_3 address_4 postcode phone_1 receive_phone_1 phone_2 receive_phone_2 email_1 receive_email_1 email_2 receive_email_2 })
        member.push *i.secondary_contact.additional_information.values_at(*additional_information_fields_for[:secondary_contact])
      end
          Severity: Minor
          Found in app/controllers/osm_exports_controller.rb and 1 other location - About 45 mins to fix
          app/controllers/osm_exports_controller.rb on lines 198..201

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if enabled_contacts[:primary_contact]
      headers.push(
        'Primary Contact 1 - First Name',
        'Primary Contact 1 - Last Name',
        'Primary Contact 1 - Address 1',
          Severity: Minor
          Found in app/controllers/osm_exports_controller.rb and 1 other location - About 35 mins to fix
          app/controllers/osm_exports_controller.rb on lines 138..156

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if enabled_contacts[:secondary_contact]
      headers.push(
        'Primary Contact 2 - First Name',
        'Primary Contact 2 - Last Name',
        'Primary Contact 2 - Address 1',
          Severity: Minor
          Found in app/controllers/osm_exports_controller.rb and 1 other location - About 35 mins to fix
          app/controllers/osm_exports_controller.rb on lines 118..136

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 36.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status