Sign upLogin

robertgauld/gandi_v5

View on GitHub
Star
lib/gandi_v5/email/mailbox.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method patch_type has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def patch_type(new_type, sharing_id, dry_run)
        fail ArgumentError unless TYPES.include?(new_type)
        return false if type == new_type

        url_ = "#{url}/type"
Severity: Minor
Found in lib/gandi_v5/email/mailbox.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def self.create(fqdn, login, password, aliases: [], type: :standard, dry_run: false)
        fail ArgumentError, "#{type.inspect} is not a valid type" unless TYPES.include?(type)
        if GandiV5::Email::Slot.list.none? { |slot| slot.mailbox_type == type && slot.inactive? }
          fail GandiV5::Error, "no available #{type} slots"
        end
Severity: Minor
Found in lib/gandi_v5/email/mailbox.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def update(**body)
        return 'Nothing to update.' if body.empty?

        check_password body[:password] if body.key?(:password)
Severity: Minor
Found in lib/gandi_v5/email/mailbox.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status