Sign upLogin

robertgauld/osm

View on GitHub
Star
lib/osm/flexi_record.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_data has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def get_data(api, term=nil, options={})
      require_ability_to(api, :read, :flexi, section_id, options)
      section = Osm::Section.get(api, self.section_id)
      term_id = term.nil? ? Osm::Term.get_current_term_for_section(api, section).id : term.to_i
      cache_key = ['flexi_record_data', id, term_id]
Severity: Minor
Found in lib/osm/flexi_record.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

      def update(api)
        raise Osm::ObjectIsInvalid, 'data is invalid' unless valid?
        require_ability_to(api, :write, :flexi, flexi_record.section_id)

        term_id = Osm::Term.get_current_term_for_section(api, flexi_record.section_id).id
Severity: Minor
Found in lib/osm/flexi_record.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def update(api)
        raise Osm::ObjectIsInvalid, 'data is invalid' unless valid?
        require_ability_to(api, :write, :flexi, flexi_record.section_id)

        term_id = Osm::Term.get_current_term_for_section(api, flexi_record.section_id).id
Severity: Minor
Found in lib/osm/flexi_record.rb - About 1 hr to fix

    Method get_data has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_data(api, term=nil, options={})
      require_ability_to(api, :read, :flexi, section_id, options)
      section = Osm::Section.get(api, self.section_id)
      term_id = term.nil? ? Osm::Term.get_current_term_for_section(api, section).id : term.to_i
      cache_key = ['flexi_record_data', id, term_id]
    Severity: Minor
    Found in lib/osm/flexi_record.rb - About 1 hr to fix

      Method update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def update(api)
        raise Osm::ObjectIsInvalid, 'column is invalid' unless valid?
        require_ability_to(api, :write, :flexi, flexi_record.section_id)
        raise Osm::Forbidden, 'this column is not editable' unless self.editable
      Severity: Minor
      Found in lib/osm/flexi_record.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method <=> has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def <=>(another)
        result = self.flexi_record <=> another.try(:flexi_record)
        if result == 0
          if id.match(/\Af_\d+\Z/)
            # This is a user column
      Severity: Minor
      Found in lib/osm/flexi_record.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method delete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def delete(api)
        require_ability_to(api, :write, :flexi, flexi_record.section_id)
        raise Osm::Forbidden, 'this column is not editable' unless self.editable

        data = api.perform_query("extras.php?action=deleteColumn&sectionid=#{flexi_record.section_id}&extraid=#{flexi_record.id}", {
      Severity: Minor
      Found in lib/osm/flexi_record.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_column has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def add_column(api, name)
      require_ability_to(api, :write, :flexi, section_id)
      raise ArgumentError, 'name is invalid' if name.blank?

      data = api.perform_query("extras.php?action=addColumn&sectionid=#{section_id}&extraid=#{id}", {
      Severity: Minor
      Found in lib/osm/flexi_record.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def <=>(another)
        result = self.flexi_record <=> another.try(:flexi_record)
        result = self.grouping_id <=> another.try(:grouping_id) if result == 0
        result = self.member_id <=> another.try(:member_id) if result == 0
        return result
      Severity: Minor
      Found in lib/osm/flexi_record.rb and 1 other location - About 30 mins to fix
      lib/osm/badge.rb on lines 499..503

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status