Sign upLogin

robertgauld/snmp_table_viewer

View on GitHub
Star

Showing 195 of 195 total issues

Line is too long. [138/80]
Open

    TYPES = CSV.read(File.join(__dir__, '..', '..', '..', 'data', 'iftable', 'type.tsv'), col_sep: "\t").each{ |i| i[0] = i[0].to_i }.to_h
Severity: Minor
Found in lib/snmp_table_viewer/converter/if_table.rb by rubocop

Trailing whitespace detected.
Open

        data_out[row] ||= Array.new
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

Surrounding space missing for operator +.
Open

            STDERR.puts "Unknown SNMP type (#{type}) on line #{index+1}: #{line}"
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Line is too long. [125/80]
Open

    # @return [Array<Array<#to_s>>] A two dimensional array containing objects in each cell (at 'address' data\[row\]\[col\])
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

Do not place comments on the same line as the end keyword.
Open

      end # each line of data_in
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Use nested module/class definitions instead of compact style.
Open

  class Converter::IfTable < Converter
Severity: Minor
Found in lib/snmp_table_viewer/converter/if_table.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Do not place comments on the same line as the end keyword.
Open

  end # IfTable Converter
Severity: Minor
Found in lib/snmp_table_viewer/converter/if_table.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Freeze mutable objects assigned to constants.
Open

  VERSION = "0.0.6"
Severity: Minor
Found in version.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

%q-literals should be delimited by ( and ).
Open

  s.description = %q{Easily view SNMP tables in a variety of different formats including as a table in the terminal, json or csv.}
Severity: Minor
Found in snmp_table_viewer.gemspec by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "rake"
Severity: Minor
Found in Rakefile by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [136/80]
Open

    opts.on('--headings-for TYPE', String, "Use headings for this table type (#{SNMPTableViewer::HEADINGS_FOR.keys.join('|')}).") do |v|
Severity: Minor
Found in bin/table-from-stdin by rubocop

Extra blank line detected.
Open
Severity: Minor
Found in bin/table-from-snmp by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Do not place comments on the same line as the end keyword.
Open

  end # CSV Formatter
Severity: Minor
Found in lib/snmp_table_viewer/formatter/csv.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Use !empty? instead of size > 0.
Open

      if @headings.size > 0
Severity: Minor
Found in lib/snmp_table_viewer/formatter/json.rb by rubocop

This cop checks for numeric comparisons that can be replaced by a predicate method, such as receiver.length == 0, receiver.length > 0, receiver.length != 0, receiver.length < 1 and receiver.size == 0 that can be replaced by receiver.empty? and !receiver.empty.

Example:

# bad
[1, 2, 3].length == 0
0 == "foobar".length
array.length < 1
{a: 1, b: 2}.length != 0
string.length > 0
hash.size > 0

# good
[1, 2, 3].empty?
"foobar".empty?
array.empty?
!{a: 1, b: 2}.empty?
!string.empty?
!hash.empty?

Extra empty line detected at class body end.
Open


  end # Formatter base class
Severity: Minor
Found in lib/snmp_table_viewer/formatter.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Line is too long. [88/80]
Open

          when 'integer', 'integer32', 'uinteger32', 'gauge32', 'counter32', 'counter64'
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

Extra empty line detected at module body end.
Open


end # module SNMPTableViewer
Severity: Minor
Found in lib/snmp_table_viewer/converter/if_table.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Space missing to the left of {.
Open

          col, row = oid.split('.')[-2..-1].map{ |i| i.to_i - 1}
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

Checks that block braces have or don't have a space before the opening brace depending on configuration.

Example:

# bad
foo.map{ |a|
  a.bar.to_s
}

# good
foo.map { |a|
  a.bar.to_s
}

Line is too long. [125/80]
Open

    # @return [Array<Array<#to_s>>] A two dimensional array containing objects in each cell (at 'address' data\[row\]\[col\])
Severity: Minor
Found in lib/snmp_table_viewer/fetcher.rb by rubocop

Surrounding space missing for operator -.
Open

        item[6] = "#{item[6]} (#{ADMIN_STATES[item[6]-1]})"
Severity: Minor
Found in lib/snmp_table_viewer/converter/if_table.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b
Severity
Category
Status
Source
Language