Sign upLogin

robotomize/fujes

View on GitHub
Star

Showing 145 of 145 total issues

SearchEngine has 39 functions (exceeds 20 allowed). Consider refactoring.
Open

class SearchEngine
{
    /**
     * @var string
     */
Severity: Minor
Found in src/robotomize/Fujes/SearchEngine.php - About 5 hrs to fix

    File SearchEngine.php has 369 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * This file is part of the Fujes package.
     * @link    https://github.com/robotomize/fujes
     * @license http://www.opensource.org/licenses/mit-license.php MIT (see the LICENSE file)
    Severity: Minor
    Found in src/robotomize/Fujes/SearchEngine.php - About 4 hrs to fix

      Method testCities has 108 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testCities()
    {
        $this->assertEquals('Vladivostok', SearchFactory::find(
            self::$prefix . self::$testUrlName[0],
            self::$testMatchString[0],
      Severity: Major
      Found in tests/FactoryTest.php - About 4 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function preSearch($inputArray = [], $key = '', $level = 0)
    {
        if (0 === count($inputArray)) {
            $inputArray = $this->inputArray;
        }
        Severity: Major
        Found in src/robotomize/Fujes/SearchSubstringCompare.php and 1 other location - About 4 hrs to fix
        src/robotomize/Fujes/SearchLevenshteinCompare.php on lines 154..182

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 168.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function preSearch($inputArray = [], $key = '', $level = 0)
    {
        if (0 === count($inputArray)) {
            $inputArray = $this->inputArray;
        }
        Severity: Major
        Found in src/robotomize/Fujes/SearchLevenshteinCompare.php and 1 other location - About 4 hrs to fix
        src/robotomize/Fujes/SearchSubstringCompare.php on lines 112..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 168.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        SearchLevenshteinCompare has 33 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class SearchLevenshteinCompare implements ISearch
{
    /**
     * @var array
     */
        Severity: Minor
        Found in src/robotomize/Fujes/SearchLevenshteinCompare.php - About 4 hrs to fix

          SearchSubstringCompare has 30 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SearchSubstringCompare implements ISearch
{
    /**
     * @var array
     */
          Severity: Minor
          Found in src/robotomize/Fujes/SearchSubstringCompare.php - About 3 hrs to fix

            The class SearchEngine has an overall complexity of 73 which is very high. The configured complexity threshold is 50.
            Open

            class SearchEngine
{
    /**
     * @var string
     */
            Severity: Minor
            Found in src/robotomize/Fujes/SearchEngine.php by phpmd

            The class SearchLevenshteinCompare has an overall complexity of 67 which is very high. The configured complexity threshold is 50.
            Open

            class SearchLevenshteinCompare implements ISearch
{
    /**
     * @var array
     */
            Severity: Minor
            Found in src/robotomize/Fujes/SearchLevenshteinCompare.php by phpmd

            The class SearchSubstringCompare has an overall complexity of 63 which is very high. The configured complexity threshold is 50.
            Open

            class SearchSubstringCompare implements ISearch
{
    /**
     * @var array
     */
            Severity: Minor
            Found in src/robotomize/Fujes/SearchSubstringCompare.php by phpmd

            Method testParseJson has 64 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testParseJson()
    {
        $searchEngine = new SearchEngine(
            self::$prefix . self::$testUrlName[0],
            self::$testMatchString[0],
            Severity: Major
            Found in tests/SearchEngineTest.php - About 2 hrs to fix

              File SearchLevenshteinCompare.php has 271 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
    /**
     * This file is part of the Fujes package.
     * @link    https://github.com/robotomize/fujes
     * @license http://www.opensource.org/licenses/mit-license.php MIT (see the LICENSE file)
              Severity: Minor
              Found in src/robotomize/Fujes/SearchLevenshteinCompare.php - About 2 hrs to fix

                SearchFacade has 23 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class SearchFacade
{

    /**
     * @var string
                Severity: Minor
                Found in src/robotomize/Fujes/SearchFacade.php - About 2 hrs to fix

                  Function __construct has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function __construct(
        $urlName,
        $matchString,
        $depth = 1,
        $jsonEncode = true,
                  Severity: Minor
                  Found in src/robotomize/Fujes/SearchEngine.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function search has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function search($inputArray = [], $key = '', $level = 0)
    {
        if (0 === count($inputArray)) {
            $inputArray = $this->inputArray;
        }
                  Severity: Minor
                  Found in src/robotomize/Fujes/SearchLevenshteinCompare.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid excessively long variable names like $directMatchCoefficient. Keep variable name length under 20.
                  Open

                      public static function setDirectMatchCoefficient($directMatchCoefficient)
                  Severity: Minor
                  Found in src/robotomize/Fujes/SearchLevenshteinCompare.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $currentIterationCount. Keep variable name length under 20.
                  Open

                          $currentIterationCount = 0;
                  Severity: Minor
                  Found in src/robotomize/Fujes/SearchSubstringCompare.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $multipleResultDefault. Keep variable name length under 20.
                  Open

                      private static $multipleResultDefault = false;
                  Severity: Minor
                  Found in src/robotomize/Fujes/SearchEngine.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $testMatchStringAnother. Keep variable name length under 20.
                  Open

                      private static $testMatchStringAnother = ['aeroflot', 'kaskoflot', 's7', 'sseven'];
                  Severity: Minor
                  Found in tests/SearchEngineTest.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Avoid excessively long variable names like $moreRelevantJsonTreesOnArray. Keep variable name length under 20.
                  Open

                      private $moreRelevantJsonTreesOnArray = [];
                  Severity: Minor
                  Found in src/robotomize/Fujes/SearchEngine.php by phpmd

                  LongVariable

                  Since: 0.2

                  Detects when a field, formal or local variable is declared with a long name.

                  Example

                  class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

                  Source https://phpmd.org/rules/naming.html#longvariable

                  Severity
                  Category
                  Status
                  Source
                  Language