Sign upLogin

rocjs/roc

View on GitHub
Star

Showing 571 of 571 total issues

Function oneOf has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function oneOf(...validators) {
    if (!validators.length) {
        throw new Error('You need to use at least one validator.');
    }
Severity: Minor
Found in src/validation/validators/oneOf.js - About 1 hr to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            it('should return info object if requested', () => {
            expect(isInteger(null, true))
                .toEqual({
                    type: 'Integer',
                    required: false,
    Severity: Major
    Found in test/validation/validators/isInteger.js and 4 other locations - About 1 hr to fix
    test/validation/validators/isBoolean.js on lines 8..17
    test/validation/validators/isFunction.js on lines 7..16
    test/validation/validators/isPromise.js on lines 7..16
    test/validation/validators/isRegExp.js on lines 8..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should return info object if requested', () => {
            expect(isPath(null, true))
                .toEqual({
                    type: 'Filepath',
                    required: false,
    Severity: Major
    Found in test/validation/validators/isPath.js and 1 other location - About 1 hr to fix
    test/validation/validators/isString.js on lines 8..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should return info object if requested', () => {
            expect(isString(null, true))
                .toEqual({
                    type: 'String',
                    required: false,
    Severity: Major
    Found in test/validation/validators/isString.js and 1 other location - About 1 hr to fix
    test/validation/validators/isPath.js on lines 8..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function getProjectExtension has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getProjectExtension(type, extensionPath, state) {
    const roc = getExtension(extensionPath, state.context.directory, type);

    if (roc) {
        try {
    Severity: Minor
    Found in src/context/extensions/steps/getExtensions.js - About 1 hr to fix

      Function runHook has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function runHook(extensionName) {
    const allHooks = getHooks();
    const extensionHooks = allHooks[extensionName];

    if (!extensionHooks) {
      Severity: Minor
      Found in src/hooks/runHook.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (error) {
                    spinner.fail();
                    log.error(
                        `Failed to download the template from ${chalk.bold(template)} using ${chalk.bold(version)}`,
                        error
        Severity: Major
        Found in src/commands/init/fetchTemplate.js and 1 other location - About 1 hr to fix
        src/commands/init/fetchTemplate.js on lines 179..185

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                try {
            const nextState = getCompleteExtensionTree(
                type,
                roc,
                extensionPath,
        Severity: Major
        Found in src/context/extensions/steps/getExtensions.js and 1 other location - About 1 hr to fix
        src/context/extensions/steps/getExtensions.js on lines 29..37

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            try {
                        return mergeState(roc.name)(previousState, state);
                    } catch (err) {
                        log.warn(
                            `Failed to load Roc ${type} ${bold(roc.name)}@${roc.version} from ${roc.path}`,
        Severity: Major
        Found in src/context/extensions/steps/getExtensions.js and 1 other location - About 1 hr to fix
        src/context/extensions/steps/getExtensions.js on lines 53..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (error) {
                    spinner.fail();
                    log.error(
                        `Failed to download the template from ${chalk.bold(template)} using ${chalk.bold(version)}`,
                        error
        Severity: Major
        Found in src/commands/init/fetchTemplate.js and 1 other location - About 1 hr to fix
        src/commands/init/fetchTemplate.js on lines 150..156

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function parseOptions has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export default function parseOptions(options, mappings, command) {
    const infoSettings = [];

    const { settings, notManaged } = parseSettingsOptions(options, mappings);
        Severity: Minor
        Found in src/cli/commands/parseOptions.js - About 1 hr to fix

          Function verifyInstalledDependencies has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export default function verifyInstalledDependencies(directory, dependencies = {}) {
    const projectJSON = require(join(directory, 'package.json')); // eslint-disable-line
    const mismatches = [];
    const allDependencies = {
        ...projectJSON.dependencies,
          Severity: Minor
          Found in src/require/verifyInstalledDependencies.js - About 1 hr to fix

            Function addRaw has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export default function addRaw(config) {
    const manageSettings = (settingsSlice) => {
        let newSettings = {};
        Object.keys(settingsSlice).forEach((key) => {
            if (isPlainObject(settingsSlice[key])) {
            Severity: Minor
            Found in src/configuration/addRaw.js - About 1 hr to fix

              Function getAlphaExtensionsThatAreNotLocked has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export default function getAlphaExtensionsThatAreNotLocked(packageJSON = {}) {
    const notLocked = {
        dependencies: [],
        devDependencies: [],
    };
              Severity: Minor
              Found in src/context/dependencies/getAlphaExtensionsThatAreNotLocked.js - About 1 hr to fix

                Function github has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                async function github(template, version) {
    // Temporary to get next for the moment
    if (!version) {
        version = defaultVersion; // eslint-disable-line
        log.info(`Will use ${chalk.bold(version)} as default version`);
                Severity: Minor
                Found in src/commands/init/fetchTemplate.js - About 1 hr to fix

                  Function getExtension has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function getExtension(extensionName, directory, type) {
    try {
        let path;

        if (extensionName.charAt(0) === '.' || isAbsolute(extensionName)) {
                  Severity: Minor
                  Found in src/context/extensions/steps/getExtensions.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function checkRequired has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function checkRequired(roc, state) {
    if (roc.required && state.settings.checkRequired) {
        for (const extension of Object.keys(roc.required)) {
            // Add roc to the usedExtensions to be able to require on that as well
            const required = [
                  Severity: Minor
                  Found in src/context/extensions/steps/getExtensions.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function commandsToMarkdown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  export default function commandsToMarkdown(
    name,
    config = {},
    commands,
    settingsLink,
                  Severity: Minor
                  Found in src/documentation/markdown/commandsToMarkdown.js - About 1 hr to fix

                    Function verifyConfigurationStructure has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    export default function verifyConfigurationStructure(config, meta, projectConfig) {
    const getKeys = (obj, oldPath = '', allKeys = [], first = true) => {
        Object.keys(obj).forEach((key) => {
            const value = obj[key];
            const newPath = oldPath + key;
                    Severity: Minor
                    Found in src/context/helpers/verifyConfigurationStructure.js - About 1 hr to fix

                      Function generateTemplate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export default function generateTemplate(name, src, dest, done) {
    const opts = getOptions(name, src);
    const metalsmith = new Metalsmith(path.join(src, 'template'));
    metalsmith.metadata({
        destDirName: path.relative(process.cwd(), dest),
                      Severity: Minor
                      Found in src/commands/init/generateTemplate/index.js - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language