Sign upLogin

rocketsofawesome/newgistics-ruby

View on GitHub
Star
lib/newgistics/requests/update_shipment_address.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [18/10]
Open

      def shipment_address_update_xml(xml)
        xml.updateShipment(shipment_address_update_attributes) do
          xml_field(xml, 'FirstName', :first_name)
          xml_field(xml, 'LastName', :last_name)
          xml_field(xml, 'Company', :company)
Severity: Minor
Found in lib/newgistics/requests/update_shipment_address.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for shipment_address_update_xml is too high. [18/15]
Open

      def shipment_address_update_xml(xml)
        xml.updateShipment(shipment_address_update_attributes) do
          xml_field(xml, 'FirstName', :first_name)
          xml_field(xml, 'LastName', :last_name)
          xml_field(xml, 'Company', :company)
Severity: Minor
Found in lib/newgistics/requests/update_shipment_address.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

There are no issues that match your filters.

Category
Status