Sign upLogin

rofrischmann/bredon

View on GitHub
Star

Showing 459 of 459 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      FunctionExpression: (node, generate) =>
        `${node.callee}(${node.params.map(generate).join(' , ')})`,
Severity: Minor
Found in packages/bredon/src/__tests__/Generator-test.js and 1 other location - About 35 mins to fix
packages/bredon-minify/src/index.js on lines 15..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function parseFunctionExpression has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  parseFunctionExpression(callee: string): FunctionNode {
    this.updateCurrentToken(2)
    ++this.parenBalance

    const startParenBalance = this.parenBalance
Severity: Minor
Found in packages/bredon/src/Parser.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseImportant has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  parseImportant(): any {
    if (this.currentToken.type === 'exclamation_mark') {
      const nextToken = this.getNextToken(1)

      if (nextToken) {
Severity: Minor
Found in packages/bredon/src/Parser.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createPath has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function createPath(
  node: ASTNode,
  parentPath?: Path,
  context?: Object = {}
): Path {
Severity: Minor
Found in packages/bredon/src/utils/createPath.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return false
Severity: Major
Found in packages/bredon-validate/src/isValidProperty.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return false
    Severity: Major
    Found in packages/bredon-validate/src/isValidProperty.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return validator(ast.body, true, isList)
      Severity: Major
      Found in packages/bredon-validate/src/isValidProperty.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return (
      // global values are always valid
      isGlobal(node) ||
      // also check for any keyword value
      matchesKeyword(property)(node) ||
        Severity: Major
        Found in packages/bredon-validate/src/isValidProperty.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return this.parseIdentifier(ident)
          Severity: Major
          Found in packages/bredon/src/Parser.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return this.parseEqual(ident)
            Severity: Major
            Found in packages/bredon/src/Parser.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return arrayReduce(
      ast.body,
      // the property is invalid as soon as one value is invalid
      // TODO: do not regenerate the value
      (isValid, cssValue) =>
              Severity: Major
              Found in packages/bredon-validate/src/isValidProperty.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false
                Severity: Major
                Found in packages/bredon-validate/src/isValidProperty.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return identifier(ident)
                  Severity: Major
                  Found in packages/bredon/src/Parser.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                              path.traverse({
            Identifier(innerPath) {
              if (innerPath.node.value === 'bar') {
                innerPath.node.value = 'baz'
              }
                    Severity: Minor
                    Found in packages/bredon/src/__tests__/Traverser-test.js and 1 other location - About 30 mins to fix
                    packages/bredon/src/__tests__/Traverser-test.js on lines 85..91

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        const visitor2 = {
      Identifier(path) {
        if (path.node.value === 'flex-end') {
          path.node.value += '-test'
        }
                    Severity: Minor
                    Found in packages/bredon/src/__tests__/Traverser-test.js and 1 other location - About 30 mins to fix
                    packages/bredon/src/__tests__/Traverser-test.js on lines 124..130

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                              ((validators.flexGrow(node[0]) &&
            validators.flexShrink(node[1]) &&
            validators.flexBasis(node[2])) ||
                    Severity: Minor
                    Found in packages/bredon-validate/src/propertyValidators.js and 1 other location - About 30 mins to fix
                    packages/bredon-validate/src/propertyValidators.js on lines 412..414

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                (validators.flexBasis(node[0]) &&
              validators.flexGrow(node[1]) &&
              validators.flexShrink(node[2]))))
                    Severity: Minor
                    Found in packages/bredon-validate/src/propertyValidators.js and 1 other location - About 30 mins to fix
                    packages/bredon-validate/src/propertyValidators.js on lines 409..411

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function flex has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      flex: (node, isMultiValue) => {
    if (isMultiValue) {
      return (
        (node.length === 2 &&
          validateUnorderedNodeList([
                    Severity: Minor
                    Found in packages/bredon-validate/src/propertyValidators.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function traverseNode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      traverseNode(visitor: Object, node: ASTNode, parentPath: Path) {
    const methods = visitor[node.type]

    const nodePath = createPath(node, parentPath, this.context)
                    Severity: Minor
                    Found in packages/bredon/src/Traverser.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language