rofrischmann/react-controlled-form

View on GitHub

Showing 7 of 7 total issues

Function createUseField has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function createUseField(resolveProps) {
  return function useField({
    name,
    value = '',
    touched = false,
Severity: Minor
Found in packages/react-controlled-form/src/factories/createUseField.js - About 1 hr to fix

    Function useFormDebugger has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function useFormDebugger(...fields) {
      const isValid = arrayReduce(
        fields,
        (isValid, field) => isValid && field.isValid,
        true
    Severity: Minor
    Found in packages/react-controlled-form/src/hooks/useFormDebugger.js - About 1 hr to fix

      Function useForm has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function useForm(...fields) {
        function touchFields() {
          fields.forEach(field => field.update({ isTouched: true }))
        }
      
      
      Severity: Minor
      Found in packages/react-controlled-form/src/hooks/useForm.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const lastname = useField({
            name: 'lastname',
            showValidationOn: 'blur',
            validation: {
              'Enter at least 2 characters.': value => value.length >= 2,
        Severity: Major
        Found in examples/simple/pages/index.js and 1 other location - About 1 hr to fix
        examples/simple/pages/index.js on lines 29..37

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const firstname = useField({
            name: 'firstname',
            showValidationOn: 'change',
            validation: {
              'Enter at least 2 characters.': value => value.length >= 2,
        Severity: Major
        Found in examples/simple/pages/index.js and 1 other location - About 1 hr to fix
        examples/simple/pages/index.js on lines 40..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          const data = arrayReduce(
            fields,
            (data, { name, value }) => {
              data[name] = value
              return data
        Severity: Minor
        Found in packages/react-controlled-form/src/hooks/useFormDebugger.js and 1 other location - About 30 mins to fix
        packages/react-controlled-form/src/hooks/useForm.js on lines 19..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const data = arrayReduce(
              fields,
              (data, { value, name }) => {
                data[name] = value
                return data
        Severity: Minor
        Found in packages/react-controlled-form/src/hooks/useForm.js and 1 other location - About 30 mins to fix
        packages/react-controlled-form/src/hooks/useFormDebugger.js on lines 12..19

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language