Sign upLogin

rogerluan/SwiftttCamera

View on GitHub
Star

Showing 8 of 8 total issues

Function rotatedImageMatchingCameraView has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    func rotatedImageMatchingCameraView(withOrientation deviceOrientation: UIDeviceOrientation) -> UIImage {
        let isMirrored: Bool = {
            switch imageOrientation {
            case .rightMirrored, .leftMirrored, .upMirrored, .downMirrored: return true
            default: return false
Severity: Minor
Found in Sources/Extensions/UIImage+Utilities.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function crop has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    internal func crop(to cropRect: CGRect?, returnsPreview: Bool, needsPreviewRotation: Bool, withPreviewOrientation previewOrientation: UIDeviceOrientation) -> Future<CapturedImage, Never> {
        return Future<CapturedImage, Never> { promise in
            self.serialQueue.async {
                if let cropRect = cropRect, cropRect != .zero {
                    self.fullImage = self.fullImage.croppedImage(fromCropRect: cropRect)
Severity: Minor
Found in Sources/CapturedImage.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    internal func scale(to maxDimension: CGFloat) -> Future<CapturedImage, Never> {
        return Future { promise in
            self.serialQueue.async {
                self.scaledImage = self.fullImage.scaledImage(withMaxDimension: maxDimension)
                promise(.success(self))
Severity: Major
Found in Sources/CapturedImage.swift and 1 other location - About 1 hr to fix
Sources/CapturedImage.swift on lines 79..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    internal func scale(to size: CGSize) -> Future<CapturedImage, Never> {
        return Future { promise in
            self.serialQueue.async {
                self.scaledImage = self.fullImage.scaledImage(ofSize: size)
                promise(.success(self))
Severity: Major
Found in Sources/CapturedImage.swift and 1 other location - About 1 hr to fix
Sources/CapturedImage.swift on lines 67..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function viewDidLoad has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override func viewDidLoad() {
        super.viewDidLoad()
        title = NSLocalizedString("SwiftttCamera Benchmark", comment: "")
        tabBarItem.image = #imageLiteral(resourceName: "bolt")
        view.backgroundColor = .systemBackground
Severity: Minor
Found in SwiftttCameraDemo/SwiftttCameraDemo/SwiftttCameraBenchmarkViewController.swift - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    public enum CameraFlashMode {
    /// Indicates that the flash should always be on.
    case on
    /// Indicates that the flash should always be off.
    case off
    Severity: Minor
    Found in Sources/CameraTypes.swift and 1 other location - About 45 mins to fix
    Sources/CameraTypes.swift on lines 55..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    public enum CameraTorchMode {
    /// Indicates that the torch should always be on.
    case on
    /// Indicates that the torch should always be off.
    case off
    Severity: Minor
    Found in Sources/CameraTypes.swift and 1 other location - About 45 mins to fix
    Sources/CameraTypes.swift on lines 37..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function previewImageOrientation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            func previewImageOrientation(forDeviceOrientation deviceOrientation: UIDeviceOrientation, isMirrored: Bool) -> UIImage.Orientation {
            switch deviceOrientation {
            case .landscapeLeft: return isMirrored ? .upMirrored : .up
            case .landscapeRight: return isMirrored ? .downMirrored : .down
            default: return isMirrored ? .leftMirrored : .right
    Severity: Minor
    Found in Sources/Extensions/UIImage+Utilities.swift - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language