Sign upLogin

rogervila/array-diff-multidimensional

View on GitHub
Star
src/helpers.php

Summary

Maintainability
A
0 mins
Test Coverage

The method array_diff_multidimensional has a boolean flag argument $strict, which is a certain sign of a Single Responsibility Principle violation.
Open

    function array_diff_multidimensional($array1, $array2, $strict = true)
Severity: Minor
Found in src/helpers.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid using static access to class '\Rogervila\ArrayDiffMultidimensional' in method 'array_diff_multidimensional'.
Open

        return ArrayDiffMultidimensional::compare($array1, $array2, $strict);
Severity: Minor
Found in src/helpers.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status