src/Contracts/ProvablyFairInterface.php
The method generate has a boolean flag argument $include_original, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function generate(int $amount, bool $include_original = false): array;- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The parameter $include_original is not named in camelCase. Open
Open
public function generate(int $amount, bool $include_original = false): array;- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}