Sign upLogin

rohanpm/pidiff

View on GitHub
Star
pidiff/_impl/dump/dump.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function import_recurse has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def import_recurse(module_name: str):
    module = importlib.import_module(module_name)

    module_file = getattr(module, "__file__", None) or ""
    if os.path.basename(module_file) == "__init__.py":
Severity: Minor
Found in pidiff/_impl/dump/dump.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_version_importlib has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def get_version_importlib(module) -> Optional[str]:
    module_file = module.__file__
    if module_file.endswith('.pyc'):
        module_file = module_file[:-1]
Severity: Minor
Found in pidiff/_impl/dump/dump.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dump_object has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def dump_object(self, ref, name, ob):
        ref_str = str(id(ob))
        ref["name"] = name
        ref["ref"] = ref_str
Severity: Minor
Found in pidiff/_impl/dump/dump.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function egg_for_root has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def egg_for_root(root_name: str):
    # FIXME: why are both mypy and pylint getting things wrong here
    # for pkg_resources? Something wrong with the setup?
    for dist in pkg_resources.working_set:  # pylint: disable=not-an-iterable
        egg_info = dist.egg_info  # type: ignore
Severity: Minor
Found in pidiff/_impl/dump/dump.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line too long (80 > 79 characters)
Open

            This module must be importable (and will be imported) by the current
Severity: Minor
Found in pidiff/_impl/dump/dump.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status