app/controllers/omniauth_callbacks_controller.rb
Method omniauth_flow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def omniauth_flow(auth_module, identity_linker: nil)
if current_user
authorize :identity_provider, :link?
identity_linker ||= auth_module::IdentityLinker.new(current_user, oauth)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Do not prefix writer method names with set_. Open
Open
def set_remember_me(user)- Read upRead up
- Exclude checks
This cop makes sure that accessor methods are named properly.
Example:
# bad
def set_attribute(value)
end
# good
def attribute=(value)
end
# bad
def get_attribute
end
# good
def attribute
end