app/controllers/profiles/passwords_controller.rb
Assignment Branch Condition size for update is too high. [<3, 20, 4> 20.62/15] Open
Open
def update
password_attributes = user_params.select do |key, _value|
%w[password password_confirmation].include?(key.to_s)
end
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.
Use nested module/class definitions instead of compact style. Open
Open
class Profiles::PasswordsController < ApplicationController
- Read upRead up
- Exclude checks
This cop checks the style of children definitions at classes and modules. Basically there are two different styles:
Example: EnforcedStyle: nested (default)
# good
# have each child on its own line
class Foo
class Bar
end
end
Example: EnforcedStyle: compact
# good
# combine definitions as much as possible
class Foo::Bar
end
The compact style is only forced for classes/modules with one child.