Sign upLogin

rokumatsumoto/boyutluseyler

View on GitHub
Star
app/helpers/tab_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Perceived complexity for active_nav_link? is too high. [11/7]
Open

  def active_nav_link?(options)
    if path = options.delete(:path)
      path = [path] unless path.respond_to?(:each)

      path.any? do |single_path|
Severity: Minor
Found in app/helpers/tab_helper.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for active_nav_link? is too high. [9/6]
Open

  def active_nav_link?(options)
    if path = options.delete(:path)
      path = [path] unless path.respond_to?(:each)

      path.any? do |single_path|
Severity: Minor
Found in app/helpers/tab_helper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method active_nav_link? has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def active_nav_link?(options)
    if path = options.delete(:path)
      path = [path] unless path.respond_to?(:each)

      path.any? do |single_path|
Severity: Minor
Found in app/helpers/tab_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for active_nav_link? is too high. [<6, 14, 10> 18.22/15]
Open

  def active_nav_link?(options)
    if path = options.delete(:path)
      path = [path] unless path.respond_to?(:each)

      path.any? do |single_path|
Severity: Minor
Found in app/helpers/tab_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Line is too long. [114/100]
Open

  #           :controller   - One or more controller names to check, use path notation when namespaced (optional).
Severity: Minor
Found in app/helpers/tab_helper.rb by rubocop

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

    if path = options.delete(:path)
Severity: Minor
Found in app/helpers/tab_helper.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

AllowSafeAssignment option for safe assignment. By safe assignment we mean putting parentheses around an assignment to indicate "I know I'm using an assignment as a condition. It's not a mistake."

Example:

# bad
if some_var = true
  do_something
end

# good
if some_var == true
  do_something
end

Example: AllowSafeAssignment: true (default)

# good
if (some_var = true)
  do_something
end

Example: AllowSafeAssignment: false

# bad
if (some_var = true)
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

    elsif page = options.delete(:page)
Severity: Minor
Found in app/helpers/tab_helper.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

AllowSafeAssignment option for safe assignment. By safe assignment we mean putting parentheses around an assignment to indicate "I know I'm using an assignment as a condition. It's not a mistake."

Example:

# bad
if some_var = true
  do_something
end

# good
if some_var == true
  do_something
end

Example: AllowSafeAssignment: true (default)

# good
if (some_var = true)
  do_something
end

Example: AllowSafeAssignment: false

# bad
if (some_var = true)
  do_something
end

There are no issues that match your filters.

Category
Status