Sign upLogin

rollbar/pyrollbar

View on GitHub
Star
rollbar/lib/transforms/serializable.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function transform_custom has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def transform_custom(self, o, key=None):
        if o is None:
            return None

        # Best to be very careful when we call user code in the middle of
Severity: Minor
Found in rollbar/lib/transforms/serializable.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function transform_dict has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def transform_dict(self, o, key=None):
        ret = {}
        for k, v in o.items():
            if isinstance(k, string_types) or isinstance(k, binary_type):
                if isinstance(k, bytes):
Severity: Minor
Found in rollbar/lib/transforms/serializable.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return '<%s in %s.__repr__: %s>' % (
Severity: Major
Found in rollbar/lib/transforms/serializable.py - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status