Sign upLogin

roma/roma

View on GitHub
Star
lib/roma/routing/random_balancer.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method randomly_change_nid! has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def randomly_change_nid!(idx, from, to, repethost = false)
        vns = []
        v_idx.each_pair do |vn, nids|
          cnt = 0
          nids.each_with_index do |nid, i|
Severity: Minor
Found in lib/roma/routing/random_balancer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_balanced_vn_replacement_list has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def get_balanced_vn_replacement_list(repethost = false)
        rd = clone
        ret = []
        @rn.times do |idx| # primary, secondary1, ...
          loop do # until balanced
Severity: Minor
Found in lib/roma/routing/random_balancer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status