Sign upLogin

romikoops/howitzer

View on GitHub
Star

Showing 26 of 26 total issues

Method record_response has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def record_response(code, link, from_url, redirection=nil)
      message = "#{code} - #{link}"

      if code.to_i >= 300
        message += " - Called from: #{from_url}"
Severity: Minor
Found in lib/howitzer/patches/rawler_patched.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File settings.rb has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'selenium-webdriver'
require 'capybara'
require 'howitzer/utils/log'
require 'howitzer/helpers'
module Capybara
Severity: Minor
Found in lib/howitzer/capybara/settings.rb - About 2 hrs to fix

    Method error has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        def error(*args)
      object = if args.first.nil?
        $!
      else
        case args.size
    Severity: Minor
    Found in lib/howitzer/utils/log.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define_browserstack_driver has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def define_browserstack_driver
      task_name = rake_task_name
      caps_opts = {
          name: "#{ENV['RAKE_TASK'] ? (task_name.empty? ? 'ALL' : task_name) : 'CUSTOM'} #{settings.bs_mobile ? settings.bs_m_browser : settings.bs_browser_name.upcase}",
          maxduration: settings.bs_max_duration.to_i,
    Severity: Minor
    Found in lib/howitzer/capybara/settings.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method define_browserstack_driver has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def define_browserstack_driver
      task_name = rake_task_name
      caps_opts = {
          name: "#{ENV['RAKE_TASK'] ? (task_name.empty? ? 'ALL' : task_name) : 'CUSTOM'} #{settings.bs_mobile ? settings.bs_m_browser : settings.bs_browser_name.upcase}",
          maxduration: settings.bs_max_duration.to_i,
    Severity: Minor
    Found in lib/howitzer/capybara/settings.rb - About 1 hr to fix

      Method copy_with_path has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def copy_with_path(data)
      src = source_path(data[:source])
      dst = dest_path(data[:destination])
      FileUtils.mkdir_p(File.dirname(dst))
      if File.exists?(dst)
      Severity: Minor
      Found in generators/base_generator.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_xml_log_item has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def add_xml_log_item(fields)
      log_file_path = File.expand_path(settings.rawler_xml_log, "#{settings.log_dir}")

      doc = File.exists?(log_file_path) ? Nokogiri::XML::Document.parse(File.read log_file_path) : Nokogiri::XML::Document.new
      Severity: Minor
      Found in lib/howitzer/patches/rawler_patched.rb - About 1 hr to fix

        Method define_sauce_driver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

              def define_sauce_driver
        task_name = rake_task_name
        caps_opts = {
          platform: settings.sl_platform,
          browser_name: settings.sl_browser_name,
        Severity: Minor
        Found in lib/howitzer/capybara/settings.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method define_testingbot_driver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

              def define_testingbot_driver
        require 'testingbot'
        task_name = rake_task_name
        caps_opts = {
          platform: settings.tb_platform,
        Severity: Minor
        Found in lib/howitzer/capybara/settings.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method wait_for_title has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def wait_for_title(expected_title, timeout=settings.timeout_small)
    warn '[Deprecated] This method is deprecated, and will be removed in next version of Howitzer'
    end_time = ::Time.now + timeout
    until ::Time.now > end_time
      operator = expected_title.is_a?(Regexp) ? :=~ : :==
        Severity: Minor
        Found in lib/howitzer/web_page.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method wait_for_url has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def wait_for_url(expected_url, timeout=settings.timeout_small)
    warn '[Deprecated] This method is deprecated, and will be removed in next version of Howitzer'
    end_time = ::Time.now + timeout
    until ::Time.now > end_time
      operator = expected_url.is_a?(Regexp) ? :=~ : :==
        Severity: Minor
        Found in lib/howitzer/web_page.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method define_testingbot_driver has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def define_testingbot_driver
        require 'testingbot'
        task_name = rake_task_name
        caps_opts = {
          platform: settings.tb_platform,
        Severity: Minor
        Found in lib/howitzer/capybara/settings.rb - About 1 hr to fix

          Method record_response has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def record_response(code, link, from_url, redirection=nil)
      message = "#{code} - #{link}"

      if code.to_i >= 300
        message += " - Called from: #{from_url}"
          Severity: Minor
          Found in lib/howitzer/patches/rawler_patched.rb - About 1 hr to fix

            Method define_sauce_driver has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def define_sauce_driver
        task_name = rake_task_name
        caps_opts = {
          platform: settings.sl_platform,
          browser_name: settings.sl_browser_name,
            Severity: Minor
            Found in lib/howitzer/capybara/settings.rb - About 1 hr to fix

              Method browser? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def browser?(*browser_aliases)
    if sauce_driver?
      log.error Howitzer::SlBrowserNotSpecifiedError, CHECK_YOUR_SETTINGS_MSG if settings.sl_browser_name.nil?
      browser_aliases.include?(settings.sl_browser_name.to_s.to_sym)
    elsif testingbot_driver?
              Severity: Minor
              Found in lib/howitzer/helpers.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def wait_for_title(expected_title, timeout=settings.timeout_small)
    warn '[Deprecated] This method is deprecated, and will be removed in next version of Howitzer'
    end_time = ::Time.now + timeout
    until ::Time.now > end_time
      operator = expected_title.is_a?(Regexp) ? :=~ : :==
              Severity: Major
              Found in lib/howitzer/web_page.rb and 1 other location - About 1 hr to fix
              lib/howitzer/web_page.rb on lines 202..209

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def wait_for_url(expected_url, timeout=settings.timeout_small)
    warn '[Deprecated] This method is deprecated, and will be removed in next version of Howitzer'
    end_time = ::Time.now + timeout
    until ::Time.now > end_time
      operator = expected_url.is_a?(Regexp) ? :=~ : :==
              Severity: Major
              Found in lib/howitzer/web_page.rb and 1 other location - About 1 hr to fix
              lib/howitzer/web_page.rb on lines 222..229

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method define_selenium_dev_driver has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def define_selenium_dev_driver
        Capybara.register_driver :selenium_dev do |app|
          profile = base_ff_profile_settings
          vendor_dir = settings.custom_vendor_dir || File.join(File.dirname(__FILE__), '..', 'vendor')
          log.error "Vendor directory was not found('#{vendor_dir}')." unless Dir.exist?(vendor_dir)
              Severity: Minor
              Found in lib/howitzer/capybara/settings.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method define_selenium_grid_driver has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def define_selenium_grid_driver
        Capybara.register_driver :selenium_grid do |app|
          caps = if ie_browser?
            ::Selenium::WebDriver::Remote::Capabilities.internet_explorer
          elsif ff_browser?
              Severity: Minor
              Found in lib/howitzer/capybara/settings.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add_locator_by_type has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def add_locator_by_type(type, name, params)
      @locators ||= {}
      @locators[self.name] ||= {}
      @locators[self.name][type] ||= {}
      log.error Howitzer::BadLocatorParamsError, args.inspect if params.nil? || (!params.is_a?(Proc) && params.empty?)
              Severity: Minor
              Found in lib/howitzer/utils/locator_store.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language