Sign upLogin

ronin-rb/ronin-brute

View on GitHub
Star

Showing 13 of 13 total issues

Method bruteforce has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

        def bruteforce(credentials)
          http = http_connect

          request_method = params[:request_method]
          path           = params[:path]
Severity: Minor
Found in lib/ronin/brute/builtin/http/login.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bruteforce has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def bruteforce(credentials)
          http = http_connect

          request_method = params[:request_method]
          path           = params[:path]
Severity: Minor
Found in lib/ronin/brute/builtin/http/login.rb - About 1 hr to fix

    Method bruteforce has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def bruteforce(credentials)
        while (username, password = credentials.dequeue)
          connect do |socket|
            # ignore the banner
            socket.gets
    Severity: Minor
    Found in lib/ronin/brute/builtin/pop3.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bruteforce has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def bruteforce(credentials)
        while (username, password = credentials.dequeue)
          tcp_connect do |socket|
            # ignore the banner
            socket.gets
    Severity: Minor
    Found in lib/ronin/brute/builtin/ftp.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_all has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def find_all(task=Async::Task.current)
        credentials = Async::LimitedQueue.new(@concurrency)

        barrier = Async::Barrier.new
        waiter  = Async::Waiter.new(parent: barrier)
    Severity: Minor
    Found in lib/ronin/brute/bruteforcer.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

                if (failure_status && response.code.to_i != failure_status) ||
               (failure_string && !response.body.include?(failure_string)) ||
               (response.kind_of?(Net::HTTPRedirection) && response['Location'] != failure_redirect)
              yield username, password
            end
    Severity: Major
    Found in lib/ronin/brute/builtin/http/login.rb - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      module Ronin
  module Brute
    #
    # Base class for all UDP service bruteforcers.
    #
      Severity: Minor
      Found in lib/ronin/brute/udp_bruteforcer.rb and 1 other location - About 35 mins to fix
      lib/ronin/brute/tcp_bruteforcer.rb on lines 25..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      module Ronin
  module Brute
    #
    # Base class for all TCP service bruteforcers.
    #
      Severity: Minor
      Found in lib/ronin/brute/tcp_bruteforcer.rb and 1 other location - About 35 mins to fix
      lib/ronin/brute/udp_bruteforcer.rb on lines 25..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method bruteforce has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def bruteforce(credentials)
        host     = params[:host]
        port     = params[:port]
        database = params[:database]
      Severity: Minor
      Found in lib/ronin/brute/builtin/mysql.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def load_bruteforcer(id)
          @bruteforcer_class = Brute.load_class(id)
        rescue Brute::ClassNotFound => error
          print_error(error.message)
          exit(1)
      Severity: Minor
      Found in lib/ronin/brute/cli/bruteforcer_command.rb and 1 other location - About 25 mins to fix
      lib/ronin/brute/cli/bruteforcer_command.rb on lines 93..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method bruteforce has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def bruteforce(credentials)
        options = {
          port: port,

          config:          false,
      Severity: Minor
      Found in lib/ronin/brute/builtin/ssh.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              def load_bruteforcer_from(file)
          @bruteforcer_class = Brute.load_class_from_file(file)
        rescue Brute::ClassNotFound => error
          print_error(error.message)
          exit(1)
      Severity: Minor
      Found in lib/ronin/brute/cli/bruteforcer_command.rb and 1 other location - About 25 mins to fix
      lib/ronin/brute/cli/bruteforcer_command.rb on lines 75..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method bruteforce has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def bruteforce(credentials)
        options = {'Host' => host, 'Port' => port}

        while (username, password = credentials.dequeue)
          telnet = Net::Telnet.new(options)
      Severity: Minor
      Found in lib/ronin/brute/builtin/telnet.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language