ronin-rb/ronin-db-activerecord

View on GitHub
lib/ronin/db/cert.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Cert has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Cert < ActiveRecord::Base

      include Model
      include Model::Importable

Severity: Minor
Found in lib/ronin/db/cert.rb - About 2 hrs to fix

    Method import has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.import(cert)
            case (public_key = cert.public_key)
            when OpenSSL::PKey::RSA
              public_key_algorithm = :rsa
              public_key_size      = public_key.n.num_bits
    Severity: Minor
    Found in lib/ronin/db/cert.rb - About 1 hr to fix

      Method import has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def self.import(cert)
              case (public_key = cert.public_key)
              when OpenSSL::PKey::RSA
                public_key_algorithm = :rsa
                public_key_size      = public_key.n.num_bits
      Severity: Minor
      Found in lib/ronin/db/cert.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status