ronin-rb/ronin-fuzzer

View on GitHub

Showing 10 of 10 total issues

Method each has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def each(string)
        return enum_for(__method__,string) unless block_given?

        matches = Set[]

Severity: Minor
Found in lib/ronin/fuzzing/mutator.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method each has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def each(string)
        return enum_for(__method__,string) unless block_given?

        matches = Set[]

Severity: Minor
Found in lib/ronin/fuzzing/mutator.rb - About 1 hr to fix

    Method fuzz_command has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

              def fuzz_command(string,index)
                Tempfile.open("ronin-fuzzer-#{index}") do |tempfile|
                  tempfile.write(string)
                  tempfile.flush
    
    
    Severity: Minor
    Found in lib/ronin/fuzzer/cli/commands/fuzz.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def initialize(fields)
            @enumerators = []
    
            fields.each do |(set,length)|
              enum = case set
    Severity: Minor
    Found in lib/ronin/fuzzing/template.rb - About 1 hr to fix

      Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def initialize(fields)
              @enumerators = []
      
              fields.each do |(set,length)|
                enum = case set
      Severity: Minor
      Found in lib/ronin/fuzzing/template.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method each has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def each(string)
              return enum_for(__method__,string) unless block_given?
      
              @rules.each do |pattern,substitution|
                scanner = StringScanner.new(string)
      Severity: Minor
      Found in lib/ronin/fuzzing/fuzzer.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_rule has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

                def parse_rule(value)
                  if value.start_with?('/')
                    unless (index = value.rindex('/:'))
                      raise(OptionParser::InvalidArgument,"argument must be of the form /REGEXP/:REPLACE, but was: #{value}")
                    end
      Severity: Minor
      Found in lib/ronin/fuzzer/cli/commands/fuzz.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

                def run
                  if @rules.empty?
                    print_error "Must specify at least one fuzzing rule"
                    exit(-1)
                  end
      Severity: Minor
      Found in lib/ronin/fuzzer/cli/commands/fuzz.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                pattern = case pattern
                          when Regexp
                            pattern
                          when String
                            Regexp.new(Regexp.escape(pattern))
      Severity: Minor
      Found in lib/ronin/fuzzing/mutator.rb and 1 other location - About 25 mins to fix
      lib/ronin/fuzzing/fuzzer.rb on lines 52..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                pattern = case pattern
                          when Regexp then pattern
                          when String then Regexp.new(Regexp.escape(pattern))
                          when Symbol then PATTERNS.const_get(pattern.upcase)
                          else
      Severity: Minor
      Found in lib/ronin/fuzzing/fuzzer.rb and 1 other location - About 25 mins to fix
      lib/ronin/fuzzing/mutator.rb on lines 60..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language