Showing 12 of 12 total issues
Class Shell
has 60 methods (exceeds 20 allowed). Consider refactoring. Open
class Shell < Resource
# Persistent environment variables for the shell.
#
# @return {Hash{String => String}]
Class RPCSession
has 50 methods (exceeds 20 allowed). Consider refactoring. Open
class RPCSession < Session
# The RPC client object.
#
# @return [#call]
Class SystemShell
has 44 methods (exceeds 20 allowed). Consider refactoring. Open
class SystemShell < Core::CLI::CommandShell
shell_name 'ronin-post_ex'
#
Class ShellSession
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
class ShellSession < Session
# The IO object used to communicate with the shell.
#
# @return [Socket, IO]
File system_shell.rb
has 326 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'ronin/core/cli/command_shell'
require 'ronin/post_ex/cli/shell_shell'
require 'ronin/post_ex/remote_file'
module Ronin
Class FS
has 28 methods (exceeds 20 allowed). Consider refactoring. Open
class FS < Resource
#
# Gets the current working directory.
#
File shell.rb
has 280 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'ronin/post_ex/resource'
require 'ronin/post_ex/cli/shell_shell'
require 'date'
Method initialize
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def initialize(session, path: nil, fd: nil)
if path
unless session.respond_to?(:fs_stat)
raise(NotImplementedError,"#{session.inspect} does not define #fs_stat")
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def initialize(session, path: nil, fd: nil)
if path
unless session.respond_to?(:fs_stat)
raise(NotImplementedError,"#{session.inspect} does not define #fs_stat")
end
Method shell_exec
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def shell_exec(command)
shell_puts("echo #{DELIMINATOR}; #{command} 2>/dev/null | base64; echo #{DELIMINATOR}")
# consume any leading output before the command output
while (line = shell_gets)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
def ioctl(command,argument)
unless @session.respond_to?(:file_ioctl)
raise(NotImplementedError,"#{@session.inspect} does not define file_ioctl")
end
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 26.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
def fcntl(command,argument)
unless @session.respond_to?(:file_fcntl)
raise(NotImplementedError,"#{@session.inspect} does not define file_fcntl")
end
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 26.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76