ronin-rb/ronin-recon

View on GitHub

Showing 30 of 30 total issues

Method validate has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

      def self.validate(data)
        unless data.kind_of?(Hash)
          raise(InvalidConfig,"must contain a Hash: #{data.inspect}")
        end

Severity: Minor
Found in lib/ronin/recon/config.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

        def process(website)
          wordlist = Wordlist.open(params[:wordlist] || DEFAULT_WORDLIST)
          queue    = Async::LimitedQueue.new(params[:concurrency])
          endpoint = Async::HTTP::Endpoint.for(
            website.scheme, website.host, port: website.port
Severity: Minor
Found in lib/ronin/recon/builtin/web/dir_enum.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

        def process(domain)
          wordlist = RECORD_NAMES
          queue    = Async::LimitedQueue.new(params[:concurrency])

          Async do |task|
Severity: Minor
Found in lib/ronin/recon/builtin/dns/srv_enum.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        def process(website)
          base_uri = website.to_uri

          Ronin::Web::Spider.site(base_uri) do |agent|
            agent.every_page do |page|
Severity: Minor
Found in lib/ronin/recon/builtin/web/spider.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Engine has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Engine

      # The configuration for the engine.
      #
      # @return [Config]
Severity: Minor
Found in lib/ronin/recon/engine.rb - About 2 hrs to fix

    Method process has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def process(website)
              wordlist = Wordlist.open(params[:wordlist] || DEFAULT_WORDLIST)
              queue    = Async::LimitedQueue.new(params[:concurrency])
              endpoint = Async::HTTP::Endpoint.for(
                website.scheme, website.host, port: website.port
    Severity: Minor
    Found in lib/ronin/recon/builtin/web/dir_enum.rb - About 1 hr to fix

      Method run has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def run(*values)
                  load_config
                  load_workers
      
                  values = values.map { |value| parse_value(value) }
      Severity: Minor
      Found in lib/ronin/recon/cli/commands/run.rb - About 1 hr to fix

        Method process has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

                def process(domain)
                  queue = Async::LimitedQueue.new(params[:concurrency])
        
                  domain_name, orig_suffix = @public_suffix_list.split(domain.name)
        
        
        Severity: Minor
        Found in lib/ronin/recon/builtin/dns/suffix_enum.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def self.validate(data)
                unless data.kind_of?(Hash)
                  raise(InvalidConfig,"must contain a Hash: #{data.inspect}")
                end
        
        
        Severity: Minor
        Found in lib/ronin/recon/config.rb - About 1 hr to fix

          Method process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

                  def process(cert)
                    subject_entries = cert.subject.to_a
                    subject_entries.each do |entry|
                      case entry[0]
                      when 'CN' # Common Name
          Severity: Minor
          Found in lib/ronin/recon/builtin/ssl/cert_enum.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

                  def process(domain)
                    wordlist = Wordlist.open(params[:wordlist] || DEFAULT_WORDLIST)
                    queue    = Async::LimitedQueue.new(params[:concurrency])
          
                    Async do |task|
          Severity: Minor
          Found in lib/ronin/recon/builtin/dns/subdomain_enum.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method process has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  def process(cert)
                    subject_entries = cert.subject.to_a
                    subject_entries.each do |entry|
                      case entry[0]
                      when 'CN' # Common Name
          Severity: Minor
          Found in lib/ronin/recon/builtin/ssl/cert_enum.rb - About 1 hr to fix

            Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                      def run(*values)
                        load_config
                        load_workers
            
                        values = values.map { |value| parse_value(value) }
            Severity: Minor
            Found in lib/ronin/recon/cli/commands/run.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method process has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    def process(domain)
                      wordlist = RECORD_NAMES
                      queue    = Async::LimitedQueue.new(params[:concurrency])
            
                      Async do |task|
            Severity: Minor
            Found in lib/ronin/recon/builtin/dns/srv_enum.rb - About 1 hr to fix

              Method process has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      def process(domain)
                        wordlist = Wordlist.open(params[:wordlist] || DEFAULT_WORDLIST)
                        queue    = Async::LimitedQueue.new(params[:concurrency])
              
                        Async do |task|
              Severity: Minor
              Found in lib/ronin/recon/builtin/dns/subdomain_enum.rb - About 1 hr to fix

                Method process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        def process(website)
                          base_uri = website.to_uri
                
                          Ronin::Web::Spider.site(base_uri) do |agent|
                            agent.every_page do |page|
                Severity: Minor
                Found in lib/ronin/recon/builtin/web/spider.rb - About 1 hr to fix

                  Method process has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          def process(domain)
                            queue = Async::LimitedQueue.new(params[:concurrency])
                  
                            domain_name, orig_suffix = @public_suffix_list.split(domain.name)
                  
                  
                  Severity: Minor
                  Found in lib/ronin/recon/builtin/dns/suffix_enum.rb - About 1 hr to fix

                    Method process_value has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def process_value(mesg)
                            worker = mesg.worker
                            value  = mesg.value
                            parent = mesg.parent
                    
                    
                    Severity: Minor
                    Found in lib/ronin/recon/engine.rb - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method intensity has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def self.intensity(new_intensity=nil)
                            if new_intensity
                              case new_intensity
                              when :passive, :active, :aggressive
                                @intensity = new_intensity
                    Severity: Minor
                    Found in lib/ronin/recon/worker.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            VALUE_FILE_NAMES = {
                              Values::Domain       => 'domains.txt',
                              Values::Mailserver   => 'mailservers.txt',
                              Values::Nameserver   => 'nameservers.txt',
                              Values::Host         => 'hosts.txt',
                    Severity: Minor
                    Found in lib/ronin/recon/output_formats/dir.rb and 1 other location - About 40 mins to fix
                    lib/ronin/recon/cli/printing.rb on lines 35..47

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 38.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language