Sign upLogin

ronin-rb/ronin-support

View on GitHub
Star

Showing 197 of 197 total issues

Class IP has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

      class IP < IPAddr

        #
        # Initializes the IP address.
        #
Severity: Minor
Found in lib/ronin/support/network/ip.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            def run
          io_array = [@io, @stdin]

          loop do
            readable, _writable, errors = IO.select(io_array,nil,io_array)
    Severity: Minor
    Found in lib/ronin/support/cli/io_shell.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method context has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            def self.context(version:   nil,
                         verify:    :none,
                         key:       nil,
                         key_file:  nil,
                         cert:      nil,
    Severity: Minor
    Found in lib/ronin/support/network/ssl.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Struct has 21 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class Struct < Memory

        # The type system used by the struct.
        #
        # @return [CTypes::StructType]
    Severity: Minor
    Found in lib/ronin/support/binary/struct.rb - About 2 hrs to fix

      Method build has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

                def self.build(method,path, # query string keyword arguments
                                      query:        nil,
                                      query_params: nil,
                                      # Basic-Auth keyword arguments
                                      user:     nil,
      Severity: Minor
      Found in lib/ronin/support/network/http/request.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                  if (byte == 42) || (byte == 45) || (byte == 46) || ((byte >= 48) && (byte <= 57)) || ((byte >= 65) && (byte <= 90)) || (byte == 95) || ((byte >= 97) && (byte <= 122))
              byte.chr
            else
              encode_byte(byte,**kwargs)
            end
      Severity: Critical
      Found in lib/ronin/support/encoding/uri.rb - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                    if (byte == 45) || (byte == 46) || ((byte >= 48) && (byte <= 57)) || ((byte >= 65) && (byte <= 90)) || (byte == 95) || ((byte >= 97) && (byte <= 122)) || (byte == 126)
              byte.chr
            elsif byte == 0x20
              '+'
            else
        Severity: Critical
        Found in lib/ronin/support/encoding/http.rb - About 2 hrs to fix

          Method build has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

                    def self.build(fields, alignment: nil, padding: true)
            members       = {}
            max_alignment = 0
            pack_string   = String.new(encoding: Encoding::ASCII_8BIT)
          Severity: Minor
          Found in lib/ronin/support/binary/ctypes/struct_type.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method read_string has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

                    def read_string(length=nil)
            new_string = if (encoding = external_encoding)
                           String.new('', encoding: encoding)
                         else
                           String.new('')
          Severity: Minor
          Found in lib/ronin/support/binary/stream/methods.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize_ssl has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

                  def initialize_ssl(ca_bundle:        nil,
                           cert:             nil,
                           cert_store:       nil,
                           ciphers:          nil,
                           extra_chain_cert: nil,
          Severity: Minor
          Found in lib/ronin/support/network/http.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def self.ok?(method=:head,url, proxy:      self.proxy,
                                       ssl:        nil,
                                       headers:    {},
                                       user_agent: nil,
                                       cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 3 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1475..1501
          lib/ronin/support/network/http.rb on lines 1577..1603
          lib/ronin/support/network/http.rb on lines 1720..1746

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def self.response_status(method=:head,url, proxy:      self.proxy,
                                                   ssl:        nil,
                                                   headers:    {},
                                                   user_agent: nil,
                                                   cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 3 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1526..1552
          lib/ronin/support/network/http.rb on lines 1577..1603
          lib/ronin/support/network/http.rb on lines 1720..1746

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def self.response_headers(method=:head,url, proxy:      self.proxy,
                                                    ssl:        nil,
                                                    headers:    {},
                                                    user_agent: nil,
                                                    cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 3 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1475..1501
          lib/ronin/support/network/http.rb on lines 1526..1552
          lib/ronin/support/network/http.rb on lines 1720..1746

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def self.response_body(method=:get,url, proxy:      self.proxy,
                                                ssl:        nil,
                                                headers:    {},
                                                user_agent: nil,
                                                cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 3 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1475..1501
          lib/ronin/support/network/http.rb on lines 1526..1552
          lib/ronin/support/network/http.rb on lines 1577..1603

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 15 locations. Consider refactoring.
          Open

                  def self.head(url, proxy:      self.proxy,
                           ssl:        nil,
                           headers:    {},
                           user_agent: nil,
                           cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 14 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1772..1799
          lib/ronin/support/network/http.rb on lines 1825..1852
          lib/ronin/support/network/http.rb on lines 1878..1905
          lib/ronin/support/network/http.rb on lines 2124..2151
          lib/ronin/support/network/http.rb on lines 2177..2204
          lib/ronin/support/network/http.rb on lines 2230..2257
          lib/ronin/support/network/http.rb on lines 2283..2310
          lib/ronin/support/network/http.rb on lines 2383..2410
          lib/ronin/support/network/http.rb on lines 2436..2463
          lib/ronin/support/network/http.rb on lines 2583..2610
          lib/ronin/support/network/http.rb on lines 2636..2663
          lib/ronin/support/network/http.rb on lines 2689..2716
          lib/ronin/support/network/http.rb on lines 2742..2769
          lib/ronin/support/network/http.rb on lines 2795..2822

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 15 locations. Consider refactoring.
          Open

                  def self.put(url, proxy:      self.proxy,
                          ssl:        nil,
                          headers:    {},
                          user_agent: nil,
                          cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 14 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1772..1799
          lib/ronin/support/network/http.rb on lines 1825..1852
          lib/ronin/support/network/http.rb on lines 1878..1905
          lib/ronin/support/network/http.rb on lines 2071..2098
          lib/ronin/support/network/http.rb on lines 2124..2151
          lib/ronin/support/network/http.rb on lines 2177..2204
          lib/ronin/support/network/http.rb on lines 2230..2257
          lib/ronin/support/network/http.rb on lines 2283..2310
          lib/ronin/support/network/http.rb on lines 2383..2410
          lib/ronin/support/network/http.rb on lines 2436..2463
          lib/ronin/support/network/http.rb on lines 2583..2610
          lib/ronin/support/network/http.rb on lines 2636..2663
          lib/ronin/support/network/http.rb on lines 2742..2769
          lib/ronin/support/network/http.rb on lines 2795..2822

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 15 locations. Consider refactoring.
          Open

                  def self.get(url, proxy:      self.proxy,
                          ssl:        nil,
                          headers:    {},
                          user_agent: nil,
                          cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 14 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1772..1799
          lib/ronin/support/network/http.rb on lines 1825..1852
          lib/ronin/support/network/http.rb on lines 2071..2098
          lib/ronin/support/network/http.rb on lines 2124..2151
          lib/ronin/support/network/http.rb on lines 2177..2204
          lib/ronin/support/network/http.rb on lines 2230..2257
          lib/ronin/support/network/http.rb on lines 2283..2310
          lib/ronin/support/network/http.rb on lines 2383..2410
          lib/ronin/support/network/http.rb on lines 2436..2463
          lib/ronin/support/network/http.rb on lines 2583..2610
          lib/ronin/support/network/http.rb on lines 2636..2663
          lib/ronin/support/network/http.rb on lines 2689..2716
          lib/ronin/support/network/http.rb on lines 2742..2769
          lib/ronin/support/network/http.rb on lines 2795..2822

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 15 locations. Consider refactoring.
          Open

                  def self.trace(url, proxy:      self.proxy,
                            ssl:        nil,
                            headers:    {},
                            user_agent: nil,
                            cookie:     nil,
          Severity: Major
          Found in lib/ronin/support/network/http.rb and 14 other locations - About 1 hr to fix
          lib/ronin/support/network/http.rb on lines 1772..1799
          lib/ronin/support/network/http.rb on lines 1825..1852
          lib/ronin/support/network/http.rb on lines 1878..1905
          lib/ronin/support/network/http.rb on lines 2071..2098
          lib/ronin/support/network/http.rb on lines 2124..2151
          lib/ronin/support/network/http.rb on lines 2177..2204
          lib/ronin/support/network/http.rb on lines 2230..2257
          lib/ronin/support/network/http.rb on lines 2283..2310
          lib/ronin/support/network/http.rb on lines 2383..2410
          lib/ronin/support/network/http.rb on lines 2436..2463
          lib/ronin/support/network/http.rb on lines 2583..2610
          lib/ronin/support/network/http.rb on lines 2636..2663
          lib/ronin/support/network/http.rb on lines 2689..2716
          lib/ronin/support/network/http.rb on lines 2795..2822

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method parse has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                    def parse(hexdump)
            return enum_for(__method__,hexdump) unless block_given?

            previous_address = nil
            first_address    = nil
          Severity: Minor
          Found in lib/ronin/support/binary/unhexdump/parser.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method encode_byte has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                  def self.encode_byte(byte, format: :decimal, zero_pad: false, **kwargs)
          case format
          when :decimal
            if zero_pad then "&#%.7d;" % byte
            else             "&#%d;" % byte
          Severity: Minor
          Found in lib/ronin/support/encoding/xml.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language