ronin-rb/ronin-support

View on GitHub
lib/ronin/support/binary/buffer.rb

Summary

Maintainability
D
2 days
Test Coverage

Class Buffer has 106 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Buffer < Memory

        include CTypes::Mixin

        #
Severity: Major
Found in lib/ronin/support/binary/buffer.rb - About 2 days to fix

    File buffer.rb has 418 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'ronin/support/binary/memory'
    require 'ronin/support/binary/byte_slice'
    require 'ronin/support/binary/ctypes/mixin'
    
    module Ronin
    Severity: Minor
    Found in lib/ronin/support/binary/buffer.rb - About 6 hrs to fix

      Method get_string has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

              def get_string(offset,length=nil)
                if (offset < 0) || (offset >= size)
                  raise(IndexError,"offset #{offset} is out of bounds: 0...#{size - 1}")
                elsif (length && (offset + length) > size)
                  raise(IndexError,"offset #{offset} or length #{length} is out of bounds: 0...#{size - 1}")
      Severity: Minor
      Found in lib/ronin/support/binary/buffer.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status