ronin-rb/ronin-web-user_agents

View on GitHub

Showing 6 of 6 total issues

Method build has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def self.build(chrome_version: ,
                       os: ,
                       os_version: nil,
                       linux_distro: nil,
                       arch: nil,
Severity: Minor
Found in lib/ronin/web/user_agents/chrome.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.build(chrome_version: ,
                       os: ,
                       os_version: nil,
                       linux_distro: nil,
                       arch: nil,
Severity: Minor
Found in lib/ronin/web/user_agents/chrome.rb - About 1 hr to fix

    Method build has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.build(firefox_version: ,
                           lang: nil,
                           encryption: nil,
                           os: ,
                           os_version: nil,
    Severity: Minor
    Found in lib/ronin/web/user_agents/firefox.rb - About 1 hr to fix

      Method build has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.build(crawler: :search, compatible: nil, chrome_version: nil)
                case crawler
                when :image
                  "Googlebot-Image/1.0"
                when :video
      Severity: Minor
      Found in lib/ronin/web/user_agents/google_bot.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method build has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def self.build(crawler: :search, compatible: nil, chrome_version: nil)
                case crawler
                when :image
                  "Googlebot-Image/1.0"
                when :video
      Severity: Minor
      Found in lib/ronin/web/user_agents/google_bot.rb - About 1 hr to fix

        Method build has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

                def self.build(firefox_version: ,
                               lang: nil,
                               encryption: nil,
                               os: ,
                               os_version: nil,
        Severity: Minor
        Found in lib/ronin/web/user_agents/firefox.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language