Sign upLogin

ronin-rb/ronin-web

View on GitHub
Star

Showing 28 of 28 total issues

Method included has 294 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def self.included(command)
          command.usage '[options] {--host HOST | --domain DOMAIN | --site URL}'

          command.option :host, value: {
                                  type:  String,
Severity: Major
Found in lib/ronin/web/cli/spider_options.rb - About 1 day to fix

    File spider_options.rb has 449 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'ronin/web/spider'
require 'ronin/support/network/http/user_agents'

module Ronin
  module Web
    Severity: Minor
    Found in lib/ronin/web/cli/spider_options.rb - About 6 hrs to fix

      Class CLI has 45 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class CLI
      #
      # Adds options for spidering a website.
      #
      # @since 2.0.0
      Severity: Minor
      Found in lib/ronin/web/cli/spider_options.rb - About 6 hrs to fix

        Class BrowserShell has 32 methods (exceeds 20 allowed). Consider refactoring.
        Open

              class BrowserShell < Core::CLI::CommandShell

        shell_name 'browser'

        # The browser instance.
        Severity: Minor
        Found in lib/ronin/web/cli/browser_shell.rb - About 4 hrs to fix

          Method run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

                    def run
            @wordlist = ::Wordlist::Builder.new(wordlist_path,**wordlist_builder_kwargs)

            @xpath = "#{@content_xpath}#{TEXT_XPATH}"
            @xpath << "|#{META_TAGS_XPATH}"                 if @parse_meta_tags
          Severity: Minor
          Found in lib/ronin/web/cli/commands/wordlist.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has 54 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                    def run
            archive = if options[:archive]
                        Web::Spider::Archive.open(options[:archive])
                      elsif options[:git_archive]
                        Web::Spider::GitArchive.open(options[:git_archive])
          Severity: Major
          Found in lib/ronin/web/cli/commands/spider.rb - About 2 hrs to fix

            Method define_printing_callbacks has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                      def define_printing_callbacks(agent)
            if options[:print_hosts]
              agent.every_host do |host|
                print_verbose "spidering new host #{host}"
              end
            Severity: Minor
            Found in lib/ronin/web/cli/commands/spider.rb - About 2 hrs to fix

              Method run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
              Open

                        def run
            proxy = Ronin::Web::Server::ReverseProxy.new do |proxy|
              proxy.on_request do |request|
                puts "[#{request.ip} -> #{request.host_with_port}] #{request.request_method} #{request.url}"
              Severity: Minor
              Found in lib/ronin/web/cli/commands/reverse_proxy.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method configure_browser has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                        def configure_browser
            if options[:x] || options[:y]
              browser.position = {
                left: options.fetch(:x,0),
                top:  options.fetch(:y,0)
              Severity: Minor
              Found in lib/ronin/web/cli/commands/browser.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                        def run
            proxy = Ronin::Web::Server::ReverseProxy.new do |proxy|
              proxy.on_request do |request|
                puts "[#{request.ip} -> #{request.host_with_port}] #{request.request_method} #{request.url}"
              Severity: Minor
              Found in lib/ronin/web/cli/commands/reverse_proxy.rb - About 1 hr to fix

                Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                          def run
            archive = if options[:archive]
                        Web::Spider::Archive.open(options[:archive])
                      elsif options[:git_archive]
                        Web::Spider::GitArchive.open(options[:git_archive])
                Severity: Minor
                Found in lib/ronin/web/cli/commands/spider.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                          def run
            db_connect if options[:import]

            vulns = []
                Severity: Minor
                Found in lib/ronin/web/cli/commands/vulns.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            def print_url(page)
            if page.code < 300
              puts "#{colors.green(page.url)} "
            elsif page.code < 400
              puts "#{colors.yellow(page.url)} "
                  Severity: Major
                  Found in lib/ronin/web/cli/commands/spider.rb and 1 other location - About 1 hr to fix
                  lib/ronin/web/cli/commands/spider.rb on lines 348..357

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 51.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                            def print_status(page)
            if page.code < 300
              print "#{colors.bright_green(page.code)} "
            elsif page.code < 400
              print "#{colors.bright_yellow(page.code)} "
                  Severity: Major
                  Found in lib/ronin/web/cli/commands/spider.rb and 1 other location - About 1 hr to fix
                  lib/ronin/web/cli/commands/spider.rb on lines 366..375

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 51.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def run
            db_connect if options[:import]

            vulns = []
                  Severity: Minor
                  Found in lib/ronin/web/cli/commands/vulns.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method define_printing_callbacks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def define_printing_callbacks(agent)
            if options[:print_hosts]
              agent.every_host do |host|
                print_verbose "spidering new host #{host}"
              end
                  Severity: Minor
                  Found in lib/ronin/web/cli/commands/spider.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method random_kwargs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def random_kwargs
            kwargs = {}

            if options[:chrome_version] && options[:browser] == :chrome
              kwargs[:chrome_version] = options[:chrome_version]
                  Severity: Minor
                  Found in lib/ronin/web/cli/commands/user_agent.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method wordlist_builder_kwargs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def wordlist_builder_kwargs
            kwargs = {}

            WORDLIST_BUILDER_OPTIONS.each do |key|
              kwargs[key] = options[key] if options.has_key?(key)
                  Severity: Minor
                  Found in lib/ronin/web/cli/commands/wordlist.rb - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method infer_wordlist_path has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def infer_wordlist_path
            if    options[:host]   then "#{options[:host]}.txt"
            elsif options[:domain] then "#{options[:domain]}.txt"
            elsif options[:site]
              uri = URI.parse(options[:site])
                  Severity: Minor
                  Found in lib/ronin/web/cli/commands/wordlist.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method print_page has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def print_page(page)
            print_status(page) if options[:print_status]
            print_url(page)

            if options[:print_headers]
                  Severity: Minor
                  Found in lib/ronin/web/cli/commands/spider.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language