Sign upLogin

rooey/chromeos-filesystem-onedrive

View on GitHub
Star

Showing 55 of 55 total issues

File onedrive_fs.js has 501 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

// Constants
// Use set DEBUG_ENABLED to true to enable verbose logging (alpha builds)
const DEBUG_ENABLED = true;
Severity: Major
Found in src/scripts/onedrive_fs.js - About 1 day to fix
  • Create a ticket

    OneDriveFS has 43 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class OneDriveFS {

    // Constructor

    constructor() {
    Severity: Minor
    Found in src/scripts/onedrive_fs.js - About 5 hrs to fix
    • Create a ticket

      Function handleError has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          handleError(error, textStatus, errorThrown) {
        const status = Number(error.status);
        if (status === 404 || status === 409) {
            console.debug(error);
            this.errorCallback_('NOT_FOUND');
      Severity: Minor
      Found in src/scripts/http_fetcher.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function assignEventHandlers has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          assignEventHandlers() {
        chrome.alarms.onAlarm.addListener(alarm => {
            if (alarm.name === 'onedrive_alarm') {
                this.onAlarm(alarm);
            }
      Severity: Major
      Found in src/scripts/onedrive_fs.js - About 2 hrs to fix
      • Create a ticket

        Function background has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const background = () => {
    if (!chrome.fileSystemProvider) {
        console.log('There is no chrome.fileSystemProvider API. See you on ChromeOS!');
        return;
    }
        Severity: Major
        Found in src/scripts/background.js - About 2 hrs to fix
        • Create a ticket

          Function handleError has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              handleError(error, textStatus, errorThrown) {
        const status = Number(error.status);
        if (status === 404 || status === 409) {
            console.debug(error);
            this.errorCallback_('NOT_FOUND');
          Severity: Minor
          Found in src/scripts/http_fetcher.js - About 1 hr to fix
          • Create a ticket

            Function mount has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                mount(successCallback, errorCallback) {
        const onedriveClient = new OneDriveClient(this);
        onedriveClient.authorize(() => {
            onedriveClient.getDriveData((driveInfo) => {
                onedriveClient.getUserInfo((userInfo) => {
            Severity: Minor
            Found in src/scripts/onedrive_fs.js - About 1 hr to fix
            • Create a ticket

              Function watchDirectory has 41 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  watchDirectory(fileSystemId, onedriveClient, entryPath) {
        this.useOptions('useWatcher', use => {
            if (!use) {
                return;
            }
              Severity: Minor
              Found in src/scripts/onedrive_fs.js - About 1 hr to fix
              • Create a ticket

                Function createEventHandler has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    createEventHandler(callback) {
        return (options, successCallback, errorCallback) => {
            const fileSystemId = options.fileSystemId;
            const onedriveClient = this.getOneDriveClient(fileSystemId);
            if (!onedriveClient) {
                Severity: Minor
                Found in src/scripts/onedrive_fs.js - About 1 hr to fix
                • Create a ticket

                  Function get has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      MetadataCache.prototype.get = function(entryPath) {
        if (entryPath === "/") {
            return {
                needFetch: true,
                exists: true
                  Severity: Minor
                  Found in src/scripts/metadata_cache.js - About 1 hr to fix
                  • Create a ticket

                    Function onClickedBtnMount has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        onClickedBtnMount(evt) {
        const btnMount = document.querySelector('#btnMount');
        evt.preventDefault();
        btnMount.setAttribute('disabled', 'true');
        $.toast({
                    Severity: Minor
                    Found in src/scripts/window.js - About 1 hr to fix
                    • Create a ticket

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Confirmed

                          useOptions(options, callback) {
        chrome.storage.local.get('settings', items => {
            const settings = items.settings || {};
            callback(settings[options] || false);
        });
                      Severity: Major
                      Found in src/scripts/onedrive_fs.js and 1 other location - About 1 hr to fix
                      src/scripts/http_fetcher.js on lines 120..125

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 61.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Confirmed

                          useOptions(options, callback) {
        chrome.storage.local.get('settings', items => {
            const settings = items.settings || {};
            callback(settings[options] || false);
        });
                      Severity: Major
                      Found in src/scripts/http_fetcher.js and 1 other location - About 1 hr to fix
                      src/scripts/onedrive_fs.js on lines 506..511

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 61.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function assignEventHandlers has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          assignEventHandlers() {
        const btnMount = document.querySelector('#btnMount');
        btnMount.addEventListener('click', e => {
            this.onClickedBtnMount(e);
        });
                      Severity: Minor
                      Found in src/scripts/window.js - About 1 hr to fix
                      • Create a ticket

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            onRemoveWatcherRequested(onedriveClient, options, successCallback, _errorCallback) {
        const watchers = this.getWatchers(options.fileSystemId);
        watchers.delete(options.entryPath);
        successCallback();
    }
                        Severity: Minor
                        Found in src/scripts/onedrive_fs.js and 1 other location - About 50 mins to fix
                        src/scripts/onedrive_fs.js on lines 183..187

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 52.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            onAddWatcherRequested(onedriveClient, options, successCallback, _errorCallback) {
        const watchers = this.getWatchers(options.fileSystemId);
        watchers.add(options.entryPath);
        successCallback();
    }
                        Severity: Minor
                        Found in src/scripts/onedrive_fs.js and 1 other location - About 50 mins to fix
                        src/scripts/onedrive_fs.js on lines 189..193

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 52.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            writeLog(messageType, message, payload) {
        if ((messageType === 'debug') && (DEBUG_ENABLED !==true)) return;
        console.log('[' + messageType + '] ' + message, payload);
        return;
    };
                        Severity: Minor
                        Found in src/scripts/onedrive_fs.js and 1 other location - About 35 mins to fix
                        src/scripts/http_fetcher.js on lines 88..92

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 46.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            writeLog(messageType, message, payload) {
        if ((messageType === 'debug') && (HTTP_DEBUG_ENABLED !==true)) return;
        console.log('[' + messageType + '] ' + message, payload);
        return;
    };
                        Severity: Minor
                        Found in src/scripts/http_fetcher.js and 1 other location - About 35 mins to fix
                        src/scripts/onedrive_fs.js on lines 461..465

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 46.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Unexpected var, use let or const instead.
                        Open

                                    var metadata = metadataList[i];
                        Severity: Minor
                        Found in src/scripts/metadata_cache.js by eslint

                        require let or const instead of var (no-var)

                        ECMAScript 6 allows programmers to create variables with block scope instead of function scope using the let and const keywords. Block scope is common in many other programming languages and helps programmers avoid mistakes such as:

                        var count = people.length;
var enoughFood = count > sandwiches.length;

if (enoughFood) {
    var count = sandwiches.length; // accidentally overriding the count variable
    console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}

// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");

                        Rule Details

                        This rule is aimed at discouraging the use of var and encouraging the use of const or let instead.

                        Examples

                        Examples of incorrect code for this rule:

                        /*eslint no-var: "error"*/

var x = "y";
var CONFIG = {};

                        Examples of correct code for this rule:

                        /*eslint no-var: "error"*/
/*eslint-env es6*/

let x = "y";
const CONFIG = {};

                        When Not To Use It

                        In addition to non-ES6 environments, existing JavaScript projects that are beginning to introduce ES6 into their codebase may not want to apply this rule if the cost of migrating from var to let is too costly. Source: http://eslint.org/docs/rules/

                        Unexpected var, use let or const instead.
                        Open

                                    var directoryPath;
                        Severity: Minor
                        Found in src/scripts/metadata_cache.js by eslint

                        require let or const instead of var (no-var)

                        ECMAScript 6 allows programmers to create variables with block scope instead of function scope using the let and const keywords. Block scope is common in many other programming languages and helps programmers avoid mistakes such as:

                        var count = people.length;
var enoughFood = count > sandwiches.length;

if (enoughFood) {
    var count = sandwiches.length; // accidentally overriding the count variable
    console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}

// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");

                        Rule Details

                        This rule is aimed at discouraging the use of var and encouraging the use of const or let instead.

                        Examples

                        Examples of incorrect code for this rule:

                        /*eslint no-var: "error"*/

var x = "y";
var CONFIG = {};

                        Examples of correct code for this rule:

                        /*eslint no-var: "error"*/
/*eslint-env es6*/

let x = "y";
const CONFIG = {};

                        When Not To Use It

                        In addition to non-ES6 environments, existing JavaScript projects that are beginning to introduce ES6 into their codebase may not want to apply this rule if the cost of migrating from var to let is too costly. Source: http://eslint.org/docs/rules/

                        Severity
                        Category
                        Status
                        Source
                        Language