Sign upLogin

rooey/chromeos-filesystem-onedrive

View on GitHub
Star
src/scripts/http_fetcher.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function handleError has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    handleError(error, textStatus, errorThrown) {
        const status = Number(error.status);
        if (status === 404 || status === 409) {
            console.debug(error);
            this.errorCallback_('NOT_FOUND');
Severity: Minor
Found in src/scripts/http_fetcher.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleError has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    handleError(error, textStatus, errorThrown) {
        const status = Number(error.status);
        if (status === 404 || status === 409) {
            console.debug(error);
            this.errorCallback_('NOT_FOUND');
Severity: Minor
Found in src/scripts/http_fetcher.js - About 1 hr to fix
  • Create a ticket

    Unnecessary semicolon.
    Open

    };
    Severity: Minor
    Found in src/scripts/http_fetcher.js by eslint

    disallow unnecessary semicolons (no-extra-semi)

    Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

    Rule Details

    This rule disallows unnecessary semicolons.

    Examples of incorrect code for this rule:

    /*eslint no-extra-semi: "error"*/

var x = 5;;

function foo() {
    // code
};

    Examples of correct code for this rule:

    /*eslint no-extra-semi: "error"*/

var x = 5;

var foo = function() {
    // code
};

    When Not To Use It

    If you intentionally use extra semicolons then you can disable this rule.

    Related Rules

    Unnecessary semicolon.
    Open

        };
    Severity: Minor
    Found in src/scripts/http_fetcher.js by eslint

    disallow unnecessary semicolons (no-extra-semi)

    Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

    Rule Details

    This rule disallows unnecessary semicolons.

    Examples of incorrect code for this rule:

    /*eslint no-extra-semi: "error"*/

var x = 5;;

function foo() {
    // code
};

    Examples of correct code for this rule:

    /*eslint no-extra-semi: "error"*/

var x = 5;

var foo = function() {
    // code
};

    When Not To Use It

    If you intentionally use extra semicolons then you can disable this rule.

    Related Rules

    FIXME found
    Open

        //FIXME #59 writeLog function should be universal @rooey
    Severity: Minor
    Found in src/scripts/http_fetcher.js by fixme

    FIXME found
    Open

        //FIXME #61 useOptions function should be universal
    Severity: Minor
    Found in src/scripts/http_fetcher.js by fixme

    FIXME found
    Open

        //FIXME #60 sendMessageToSentry should be universal
    Severity: Minor
    Found in src/scripts/http_fetcher.js by fixme

    Identical blocks of code found in 2 locations. Consider refactoring.
    Confirmed

        useOptions(options, callback) {
        chrome.storage.local.get('settings', items => {
            const settings = items.settings || {};
            callback(settings[options] || false);
        });
    Severity: Major
    Found in src/scripts/http_fetcher.js and 1 other location - About 1 hr to fix
    src/scripts/onedrive_fs.js on lines 506..511

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        writeLog(messageType, message, payload) {
        if ((messageType === 'debug') && (HTTP_DEBUG_ENABLED !==true)) return;
        console.log('[' + messageType + '] ' + message, payload);
        return;
    };
    Severity: Minor
    Found in src/scripts/http_fetcher.js and 1 other location - About 35 mins to fix
    src/scripts/onedrive_fs.js on lines 461..465

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status