Sign upLogin

rootlocal/yii2-image2

View on GitHub
Star

Showing 21 of 21 total issues

Function resize has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

    public function resize($width = null, $height = null, $master = null)
    {
        if ($master === null) {
            // Choose the master dimension automatically
            $master = Image::AUTO;
Severity: Minor
Found in src/components/Kohana/Image.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Image_GD.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace image\components\drivers;

use yii\base\ErrorException;
Severity: Minor
Found in src/components/drivers/Image_GD.php - About 3 hrs to fix

    Method resize has 83 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function resize($width = null, $height = null, $master = null)
    {
        if ($master === null) {
            // Choose the master dimension automatically
            $master = Image::AUTO;
    Severity: Major
    Found in src/components/Kohana/Image.php - About 3 hrs to fix

      Method crop has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function crop($width, $height, $offset_x = null, $offset_y = null)
    {
        if ($width > $this->width) {
            // Use the current width
            $width = $this->width;
      Severity: Minor
      Found in src/components/Kohana/Image.php - About 1 hr to fix

        Method _do_reflection has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _do_reflection($height, $opacity, $fade_in)
    {
        if (empty(Image_GD::$_available_functions[Image_GD::IMAGEFILTER])) {
            throw new ErrorException('This method requires imagefilter, which is only available in the bundled version of GD');
        }
        Severity: Minor
        Found in src/components/drivers/Image_GD.php - About 1 hr to fix

          Method create has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function create()
    {
        $ImageDriver = new Image(['driver' => $this->driver]);
        $ImageDriver = $ImageDriver->load($this->file);
          Severity: Minor
          Found in src/components/Thumb.php - About 1 hr to fix

            Function crop has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function crop($width, $height, $offset_x = null, $offset_y = null)
    {
        if ($width > $this->width) {
            // Use the current width
            $width = $this->width;
            Severity: Minor
            Found in src/components/Kohana/Image.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method _do_adapt has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function _do_adapt($width, $height, $bg_width, $bg_height, $offset_x, $offset_y)
            Severity: Minor
            Found in src/components/drivers/Image_Imagick.php - About 45 mins to fix

              Method _do_adapt has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function _do_adapt($width, $height, $bg_width, $bg_height, $offset_x, $offset_y)
              Severity: Minor
              Found in src/components/drivers/Driver.php - About 45 mins to fix

                Function save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function save($file = null, $quality = 100)
    {
        if ($file === null) {
            // Overwrite the file
            $file = $this->file;
                Severity: Minor
                Found in src/components/Kohana/Image.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method _do_adapt has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function _do_adapt($width, $height, $bg_width, $bg_height, $offset_x, $offset_y);
                Severity: Minor
                Found in src/components/drivers/DriverInterface.php - About 45 mins to fix

                  Method _do_adapt has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function _do_adapt($width, $height, $bg_width, $bg_height, $offset_x, $offset_y)
                  Severity: Minor
                  Found in src/components/drivers/Image_GD.php - About 45 mins to fix

                    Function _do_resize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function _do_resize($width, $height)
    {
        // Presize width and height
        $pre_width = $this->width;
        $pre_height = $this->height;
                    Severity: Minor
                    Found in src/components/drivers/Image_GD.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _do_reflection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function _do_reflection($height, $opacity, $fade_in)
    {
        if (empty(Image_GD::$_available_functions[Image_GD::IMAGEFILTER])) {
            throw new ErrorException('This method requires imagefilter, which is only available in the bundled version of GD');
        }
                    Severity: Minor
                    Found in src/components/drivers/Image_GD.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function __construct($file)
    {
        if (!Image_GD::$_checked) {
            // Run the install check
            Image_GD::check();
                    Severity: Minor
                    Found in src/components/drivers/Image_GD.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($offset_x === null) {
            // Center the X offset
            $offset_x = round(($this->width - $watermark->width) / 2);
        } elseif ($offset_x === true) {
            // Bottom the X offset
                    Severity: Minor
                    Found in src/components/Kohana/Image.php and 1 other location - About 30 mins to fix
                    src/components/Kohana/Image.php on lines 451..460

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 91.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($offset_y === null) {
            // Center the Y offset
            $offset_y = round(($this->height - $watermark->height) / 2);
        } elseif ($offset_y === true) {
            // Bottom the Y offset
                    Severity: Minor
                    Found in src/components/Kohana/Image.php and 1 other location - About 30 mins to fix
                    src/components/Kohana/Image.php on lines 440..449

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 91.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function _save_function has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function _save_function($extension, & $quality)
    {
        if (!$extension) {
            // Use the current image type
            $extension = image_type_to_extension($this->type, false);
                    Severity: Minor
                    Found in src/components/drivers/Image_GD.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function create()
    {
        $ImageDriver = new Image(['driver' => $this->driver]);
        $ImageDriver = $ImageDriver->load($this->file);
                    Severity: Minor
                    Found in src/components/Thumb.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _do_flip has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function _do_flip($direction)
    {
        // Create the flipped image
        $flipped = $this->_create($this->width, $this->height);
                    Severity: Minor
                    Found in src/components/drivers/Image_GD.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language