Sign upLogin

rootslab/boris

View on GitHub
Star

Showing 14 of 14 total issues

Function Boris has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

exports.Boris = ( function () {
    // Buffer concat, node >= 0.8
    var bconcat = Buffer.concat
        , util = require( 'util' )
        , emitter = require( 'events' ).EventEmitter
Severity: Minor
Found in lib/boris.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Boris has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.Boris = ( function () {
    // Buffer concat, node >= 0.8
    var bconcat = Buffer.concat
        , util = require( 'util' )
        , emitter = require( 'events' ).EventEmitter
Severity: Major
Found in lib/boris.js - About 5 hrs to fix

    Function BulkRule has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.BulkRule = ( function () {
    var Rule = require('./rule').Rule
        , util = require( 'util' )
        , BulkRule = function ( char ) {
            var me = this
    Severity: Minor
    Found in lib/rules/bulk.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var Rule = require('./rule').Rule
        , util = require( 'util' )
        , StatusRule = function ( char ) {
            var me = this
                , is = me instanceof StatusRule
    Severity: Major
    Found in lib/rules/status.js and 1 other location - About 2 hrs to fix
    lib/rules/basic.js on lines 6..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var Rule = require('./rule').Rule
        , util = require( 'util' )
        , BasicRule = function ( char ) {
            var me = this
                , is = me instanceof BasicRule
    Severity: Major
    Found in lib/rules/basic.js and 1 other location - About 2 hrs to fix
    lib/rules/status.js on lines 6..17

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function BulkRule has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.BulkRule = ( function () {
    var Rule = require('./rule').Rule
        , util = require( 'util' )
        , BulkRule = function ( char ) {
            var me = this
    Severity: Major
    Found in lib/rules/bulk.js - About 2 hrs to fix

      Function Rule has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.Rule = ( function () {
    var emitter = require('events').EventEmitter
        , util = require( 'util' )
        , Abaco = require( 'abaco' )
        // match CRLF value
      Severity: Minor
      Found in lib/rules/rule.js - About 1 hr to fix

        Function parse has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            bproto.parse = function ( data, pos ) {
        var me = this
            , dlen = data.length
            , p = pos || 0
            , curry = 0
        Severity: Minor
        Found in lib/rules/bulk.js - About 1 hr to fix

          Function Rule has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.Rule = ( function () {
    var emitter = require('events').EventEmitter
        , util = require( 'util' )
        , Abaco = require( 'abaco' )
        // match CRLF value
          Severity: Minor
          Found in lib/rules/rule.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function MultiBulkRule has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.MultiBulkRule = ( function () {
    var Rule = require('./rule').Rule
        , util = require( 'util' )
        , MultiBulkRule = function ( char ) {
            var me = this
          Severity: Minor
          Found in lib/rules/mbulk.js - About 1 hr to fix

            Function collectResult has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    , collectResult = function ( rule, error, data ) {
            var me = this
                , arr = null
                , peela = me.peela
                , head = peela.head()
            Severity: Minor
            Found in lib/boris.js - About 1 hr to fix

              Function MultiBulkRule has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.MultiBulkRule = ( function () {
    var Rule = require('./rule').Rule
        , util = require( 'util' )
        , MultiBulkRule = function ( char ) {
            var me = this
              Severity: Minor
              Found in lib/rules/mbulk.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                          return [ me, false, d, v + 2, data ];
              Severity: Major
              Found in lib/rules/bulk.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return [ me, false, d, m, data ];
                Severity: Major
                Found in lib/rules/bulk.js - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language